Bug 212057

Summary: REGRESSION(r260760): ENABLE_GRAPHICS_CONTEXT_GL should be ON, not TRUE
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bugs-noreply, cgarcia, ews-watchlist, gyuyoung.kim, mcatanzaro, ryuan.choi, sergio
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Description Michael Catanzaro 2020-05-18 17:45:44 PDT 
Our feature list after r260760, ENABLE_GRAPHICS_CONTEXT_GL is messed up:

-- Enabled features:
--  ENABLE_ACCELERATED_2D_CANVAS .................. OFF
--  ENABLE_BUBBLEWRAP_SANDBOX                       ON
--  ENABLE_DRAG_SUPPORT ........................... ON
--  ENABLE_GLES2                                    ON
--  ENABLE_GRAPHICS_CONTEXT_GL .................... TRUE
--  ENABLE_GTKDOC                                   OFF
--  ENABLE_INTROSPECTION .......................... ON
--  ENABLE_MEDIA_SOURCE                             ON
--  ENABLE_MINIBROWSER ............................ ON
--  ENABLE_QUARTZ_TARGET                            OFF
--  ENABLE_SHAREABLE_RESOURCE ..................... ON
--  ENABLE_SPELLCHECK                               ON
--  ENABLE_TOUCH_EVENTS ........................... ON
--  ENABLE_VIDEO                                    ON
--  ENABLE_WAYLAND_TARGET ......................... ON
--  ENABLE_WEBDRIVER                                ON
--  ENABLE_WEB_AUDIO .............................. ON
--  ENABLE_WEB_CRYPTO                               ON
--  ENABLE_X11_TARGET ............................. ON
--  USE_GTK4                                        OFF
--  USE_LIBHYPHEN ................................. ON
--  USE_LIBNOTIFY                                   ON
--  USE_LIBSECRET ................................. ON
--  USE_OPENJPEG                                    ON
--  USE_SYSTEMD ................................... ON
--  USE_WOFF2                                       ON
--  USE_WPE_RENDERER .............................. ON

Since multiple variables were merged together, I think we can just remove the line that sets it explicitly. Let's see.
Comment 1 Michael Catanzaro 2020-05-18 18:29:39 PDT 
Created attachment 399693 [details]
Patch
Comment 2 Michael Catanzaro 2020-05-18 18:32:47 PDT 
(In reply to Michael Catanzaro from comment #0)
> Since multiple variables were merged together, I think we can just remove
> the line that sets it explicitly. Let's see.

To be completely sure, I checked to ensure poster circle still works. Seems fine.
Comment 3 Michael Catanzaro 2020-06-16 14:31:09 PDT 
Ping reviewers.
Comment 4 EWS 2020-06-17 00:30:00 PDT 
Committed r263138: <https://trac.webkit.org/changeset/263138>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399693 [details].