Summary: | [GTK] Allow gtk-doc and introspection in cross builds | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> | ||||
Component: | WebKitGTK | Assignee: | Michael Catanzaro <mcatanzaro> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | annulen, aperez, bugs-noreply, ews-watchlist, gyuyoung.kim, mcatanzaro, ryuan.choi, sergio | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Michael Catanzaro
2020-05-18 07:58:40 PDT
Created attachment 399647 [details]
Patch
Comment on attachment 399647 [details]
Patch
I think this is from before the times packagers figured out that they
could run gtk-doc and/or g-ir-scanner/g-ir-generate using qemu userspace
emulation to allow running code for the target platform when doing a
cross-compiled build. While that's a terrible hack and ideally GTK-Doc
and GI should support cross-compilation better, it's true that it is
no longer needed to forcibly disable these two options 🤔️
Let's land this.
Committed r261814: <https://trac.webkit.org/changeset/261814> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399647 [details]. I'm pretty sure we're not using qemu or anything special? *shrug* (In reply to Michael Catanzaro from comment #4) > I'm pretty sure we're not using qemu or anything special? *shrug* In case you feel like doing some oddball build tooling archeology... I have no idea how Fedora (which I suppose is the “we” there) wrangles this, but I am sure that's how Yocto and Buildroot do it: https://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/classes/gobject-introspection.bbclass#n28 https://git.busybox.net/buildroot/tree/package/gobject-introspection/gobject-introspection.mk#n96 As for Flatpak, if you do a cross-build the whole build sandbox runs inside the qemu userspace emulator. (In reply to Adrian Perez from comment #5) > I have no idea how Fedora (which I suppose is the “we” there) wrangles > this, but I am sure that's how Yocto and Buildroot do it: No, Fedora never cross builds anything, we do native builds only. Maybe armv7 builds are done in a VM or something, dunno. Here "we" is GNOME, I'm trying to upstream this GNOME patch. > As for Flatpak, if you do a cross-build the whole build sandbox runs > inside the qemu userspace emulator. Probably that explains why it works for GNOME. (In reply to Michael Catanzaro from comment #6) > No, Fedora never cross builds anything, we do native builds only. Maybe > armv7 builds are done in a VM or something, dunno. Here "we" is GNOME, I'm > trying to upstream this GNOME patch. Ugh, sorry. There "we" in the first sentence meant Fedora, and in the third second meant GNOME. I can probably change my "we" multiple times in the same sentence if not careful. So many hats.... |