Summary: | [JSC] Silence unused-but-set-parameter warnings for older compilers | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Lauro Moura <lmoura> | ||||||
Component: | JavaScriptCore | Assignee: | Lauro Moura <lmoura> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, mcatanzaro, msaboff, saam, tzagallo, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=211701 | ||||||||
Attachments: |
|
Description
Lauro Moura
2020-05-17 19:17:48 PDT
Created attachment 399614 [details]
Patch
Comment on attachment 399614 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399614&action=review > Source/JavaScriptCore/jit/CCallHelpers.h:111 > + // Silence some older compilers (GCC up to 9.X) about unused but set parameters. > + (void)sources; > + (void)destinations; We have standard idiom for this: see uses of UNUSED_PARAM in the code. Created attachment 399619 [details]
Updated patch with UNUSED_PARAM
Committed r261797: <https://trac.webkit.org/changeset/261797> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399619 [details]. Thanks for keeping the build clean. :) |