Bug 211971

Summary: OES_texture_float internal format conversion must depend on WEBGL_color_buffer_float
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, graouts, jdarpinian, justin_fan, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 210994    
Bug Blocks: 210524    
Attachments:
Description Flags
Patch none

Kenneth Russell
Reported 2020-05-15 15:32:17 PDT
In Bug 210994, WebKit's OES_texture_float WebGL 1.0 extension implementation was changed to modify the internal format of incoming GL_RGB or GL_RGBA textures of type GL_FLOAT. This conversion must be made conditional in order to not break the extension on iOS when OES_texture_float is exposed, since WEBGL_color_buffer_float will not be exposed on those devices.
Attachments
Patch (5.46 KB, patch)
2020-05-15 15:35 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2020-05-15 15:35:29 PDT
Created attachment 399520 [details] Patch
EWS
Comment 2 2020-05-15 16:57:28 PDT
Committed r261769: <https://trac.webkit.org/changeset/261769> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399520 [details].
Radar WebKit Bug Importer
Comment 3 2020-05-15 16:58:17 PDT
<rdar://problem/63294727>
Note You need to log in before you can comment on or make changes to this bug.