Bug 211952

Summary: [JSC] Make OutOfMemory error as instance of RangeError
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, ross.kirsling, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Yusuke Suzuki
Reported 2020-05-15 05:50:42 PDT
[JSC] Make OutOfMemory error as instance of RangeError
Attachments
Patch (1.76 KB, patch)
2020-05-15 05:51 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (64.18 KB, patch)
2020-05-15 05:58 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (78.35 KB, patch)
2020-05-15 11:02 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (78.47 KB, patch)
2020-05-15 11:07 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (78.88 KB, patch)
2020-05-15 18:50 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2020-05-15 05:51:19 PDT
Created attachment 399471 [details] Patch WIP
Yusuke Suzuki
Comment 2 2020-05-15 05:58:15 PDT
Created attachment 399472 [details] Patch WIP
Yusuke Suzuki
Comment 3 2020-05-15 11:02:26 PDT
Created attachment 399495 [details] Patch
Yusuke Suzuki
Comment 4 2020-05-15 11:07:39 PDT
Created attachment 399497 [details] Patch
Ross Kirsling
Comment 5 2020-05-15 16:54:57 PDT
Nice. Does this have any test262 impact?
Yusuke Suzuki
Comment 6 2020-05-15 18:50:29 PDT
Created attachment 399536 [details] Patch
Yusuke Suzuki
Comment 7 2020-05-15 18:51:04 PDT
(In reply to Ross Kirsling from comment #5) > Nice. Does this have any test262 impact? Looks like no impact.
Mark Lam
Comment 8 2020-05-15 20:07:48 PDT
Comment on attachment 399536 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399536&action=review r=me > Source/JavaScriptCore/runtime/ErrorType.h:54 > +#define COUNT_ERROR_TYPES(name) 1 + > +static constexpr unsigned NumberOfErrorType { > + JSC_ERROR_TYPES(COUNT_ERROR_TYPES) 0 Nice. I never thought of doing it this way to do the counting.
EWS
Comment 9 2020-05-16 01:24:28 PDT
Committed r261780: <https://trac.webkit.org/changeset/261780> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399536 [details].
Radar WebKit Bug Importer
Comment 10 2020-05-16 01:25:17 PDT
<rdar://problem/63302744>
Note You need to log in before you can comment on or make changes to this bug.