Bug 211920

Summary: Make sure we use current data store in WKTR's TestController
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Tools / TestsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Chris Dumez 2020-05-14 13:49:49 PDT
Make sure we use current data store in WKTR's TestController. Currently, a lot of code uses defaultDataStore(), even though the test may be using another data store (e.g. an ephemeral one). I suspect this is contributing to test flakiness.
Comment 1 Chris Dumez 2020-05-14 13:51:04 PDT
Created attachment 399404 [details]
Patch
Comment 2 Chris Dumez 2020-05-14 15:27:49 PDT
Created attachment 399417 [details]
Patch
Comment 3 Chris Dumez 2020-05-14 16:16:44 PDT
Created attachment 399424 [details]
Patch
Comment 4 Chris Dumez 2020-05-14 16:22:59 PDT
Created attachment 399425 [details]
Patch
Comment 5 Chris Dumez 2020-05-14 18:55:16 PDT
Created attachment 399440 [details]
Patch
Comment 6 EWS 2020-05-15 13:50:22 PDT
Committed r261758: <https://trac.webkit.org/changeset/261758>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399440 [details].
Comment 7 Radar WebKit Bug Importer 2020-05-15 13:51:14 PDT
<rdar://problem/63287645>