Summary: | Make editing-word-with-marker-1.html work on iOS | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||||
Component: | Tools / Tests | Assignee: | Daniel Bates <dbates> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ddkilzer, simon.fraser, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Local Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=211802 | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 211802 | ||||||||||
Attachments: |
|
Description
Daniel Bates
2020-05-12 16:05:02 PDT
Created attachment 399195 [details]
Patch
Comment on attachment 399195 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399195&action=review > LayoutTests/editing/mac/spelling/editing-word-with-marker-1.html:61 > + textarea.focus(); Why don't we have to do the same thing here as resetText() when calling textarea.focus()? if (window.testRunner) await UIHelper.activateElementAndWaitForInputSession(textarea); else textarea.focus(); Comment on attachment 399195 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399195&action=review >> LayoutTests/editing/mac/spelling/editing-word-with-marker-1.html:61 >> + textarea.focus(); > > Why don't we have to do the same thing here as resetText() when calling textarea.focus()? > > if (window.testRunner) > await UIHelper.activateElementAndWaitForInputSession(textarea); > else > textarea.focus(); Focus() not needed. Will remove. It's a no-op in the context of this patch. Thanks Simon! Created attachment 399620 [details]
To Land
Created attachment 399621 [details]
To Land
Committed r261796: <https://trac.webkit.org/changeset/261796> |