Bug 211810

Summary: handling of Check in VarargsForwardingPhase is too pessimistic
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, fpizlo, ggaren, gskachkov, guijemont, keith_miller, mark.lam, msaboff, rmorisset, ross.kirsling, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
keith_miller: review+
patch for landing none

Saam Barati
Reported 2020-05-12 15:30:05 PDT
...
Attachments
patch (3.34 KB, patch)
2020-05-12 16:03 PDT, Saam Barati 		keith_miller: review+
DetailsFormatted DiffDiff
patch for landing (3.31 KB, patch)
2020-05-12 17:09 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2020-05-12 16:03:47 PDT
Created attachment 399194 [details] patch
Keith Miller
Comment 2 2020-05-12 16:05:39 PDT
Comment on attachment 399194 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=399194&action=review r=me. > JSTests/microbenchmarks/forward-varargs-check-shouldnt-escape.js:14 > +// print(Date.now() - start); Plox delete.
Saam Barati
Comment 3 2020-05-12 17:09:03 PDT
Created attachment 399205 [details] patch for landing
EWS
Comment 4 2020-05-12 20:05:01 PDT
Committed r261595: <https://trac.webkit.org/changeset/261595> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399205 [details].
Radar WebKit Bug Importer
Comment 5 2020-05-12 20:06:13 PDT
<rdar://problem/63166410>
Note You need to log in before you can comment on or make changes to this bug.