Bug 21180 – console.trace should show file and line number for each function in the stack

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Timothy Hatcher]

The file and line number should be shown next to each function name. Right now anonymous functions are impossible to distinguish.

The line number should be the point where the execution called the next function in the stack, not the line where the function was declared.

[Yury Semikhatsky]

Created attachment 61791 [details]
Patch

[Pavel Feldman]

Comment on attachment 61791 [details]
Patch

Formally correct, but I'd like you to use TreeOutline instead of a custom list.

WebCore/bindings/v8/ScriptCallStack.cpp:124
 +      if (m_stackTrace.get().IsEmpty())
Do we need a handle to stack trace here?

WebCore/bindings/v8/ScriptCallStack.h:76
 +      OwnPtr<ScriptCallFrame> m_topFrame;
Can we make it value type?

WebCore/bindings/v8/custom/V8ConsoleCustom.cpp:69
 +      v8::Local<v8::StackTrace> stackTrace = v8::StackTrace::CurrentStackTrace(20000);
200?

WebCore/inspector/ConsoleMessage.cpp:140
 +              frames.set(i, m_frames.at(i).createFrontendObject(frontend));
buildObjectForFrame

WebCore/inspector/front-end/ConsoleView.js:832
 +                  var urlElement = this._createSourceUrlLink(this.url, this.line);
_createSourceURLLink

WebCore/inspector/front-end/ConsoleView.js:844
 +                  var ol = this._createStackTraceElement();
You should use TreeOutline and TreeItem here.

[Yury Semikhatsky]

Created attachment 61800 [details]
Patch

[Yury Semikhatsky]

Addressed all the comments.

[Pavel Feldman]

Comment on attachment 61800 [details]
Patch

Please test well prior to landing.

[Yury Semikhatsky]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	M	LayoutTests/http/tests/inspector/console-tests.js
	A	LayoutTests/inspector/console-trace-expected.txt
	A	LayoutTests/inspector/console-trace.html
	M	WebCore/ChangeLog
	M	WebCore/bindings/js/ScriptCallStack.cpp
	M	WebCore/bindings/v8/ScriptCallFrame.cpp
	M	WebCore/bindings/v8/ScriptCallFrame.h
	M	WebCore/bindings/v8/ScriptCallStack.cpp
	M	WebCore/bindings/v8/ScriptCallStack.h
	M	WebCore/bindings/v8/custom/V8ConsoleCustom.cpp
	M	WebCore/inspector/ConsoleMessage.cpp
	M	WebCore/inspector/ConsoleMessage.h
	M	WebCore/inspector/front-end/ConsoleView.js
	M	WebCore/inspector/front-end/inspector.css
	M	WebCore/page/Console.idl
Committed r63548

[WebKit Review Bot]

http://trac.webkit.org/changeset/63548 might have broken Chromium Linux Release

[Simon Hausmann]

Revision r63548 cherry-picked into qtwebkit-2.1 with commit ca8729b0b71bda22694cb564737ef520765c6ae5

[Ademar Reis]

This bug is marked as RESOLVED/FIXED but it depends on an open-bug: #13646

Should the dependency be removed? Maybe bug #13646 should block the qtwebkit-2.1 release bug instead? (bug #39121)