Bug 21175

Summary: Store the callee CodeBlock, not the caller CodeBlock, in the call frame header
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: JavaScriptCoreAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
patch ggaren: review+

Geoffrey Garen
Reported 2008-09-27 09:53:05 PDT
Patch coming.
Attachments
patch (68.01 KB, patch)
2008-09-27 09:53 PDT, Geoffrey Garen 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2008-09-27 09:53:27 PDT
Created attachment 23877 [details] patch
Geoffrey Garen
Comment 2 2008-09-27 09:57:18 PDT
Forgot to mention in ChangeLog: Small regression in bytecode, because currently every op_ret reads the callee CodeBlock to check needsFullScopeChain, and bytecode does not keep "r" in a register. On-balance, this is probably OK, since CTI is our high-performance execution model. Also, this should go away once we make needsFullScopeChain statically determinable at parse time.
Cameron Zwarich (cpst)
Comment 3 2008-09-27 10:14:28 PDT
Comment on attachment 23877 [details] patch r=me
Geoffrey Garen
Comment 4 2008-09-27 10:16:10 PDT
Comment on attachment 23877 [details] patch r+ based on Cameron's comment.
Geoffrey Garen
Comment 5 2008-09-27 10:27:58 PDT
http://trac.webkit.org/changeset/36997
Note You need to log in before you can comment on or make changes to this bug.