Bug 211705

Summary: Add copy constructor and assignment operator to Ref<>
Product: WebKit Reporter: Darin Adler <darin>
Component: Web Template FrameworkAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, dbates, esprehn+autocc, ews-watchlist, ggaren, kangil.han, kling, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review+

Darin Adler
Reported 2020-05-10 16:36:42 PDT
Add copy constructor and assignment operator to Ref<>
Attachments
Patch (6.07 KB, patch)
2020-05-10 16:42 PDT, Darin Adler 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2020-05-10 16:42:46 PDT
Created attachment 398986 [details] Patch
Darin Adler
Comment 2 2020-05-10 16:46:11 PDT
Comment on attachment 398986 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398986&action=review > Source/WTF/ChangeLog:19 > + These follow a similar patter to the move constructor and assignment operator. probably should spell it "pattern".
Chris Dumez
Comment 3 2020-05-10 22:32:10 PDT
I am glad Ref will finally have this.
Darin Adler
Comment 4 2020-05-10 23:15:01 PDT
Committed r261467: <https://trac.webkit.org/changeset/261467>
Radar WebKit Bug Importer
Comment 5 2020-05-10 23:15:18 PDT
<rdar://problem/63077127>
Andreas Kling
Comment 6 2020-06-11 04:24:24 PDT
Great change! :) In retrospect, efforts to avoid refcount churn are probably best limited to situations where it has a measurable impact on performance, and should not be a goal in itself.
Darin Adler
Comment 7 2020-06-12 13:34:44 PDT
Thank you, sir. Great to get a vote of confidence from the "founder of the [Ref class template] feast".
Note You need to log in before you can comment on or make changes to this bug.