Bug 211673

Summary: [macOS] Search field on mayoclinic.org/forms/us-resident-appointment clips the submit button
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: FormsAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, cdumez, changseok, dino, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, thorton, webkit-bug-importer, wenson_hsieh, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Wenson Hsieh
Reported 2020-05-09 16:10:37 PDT
<rdar://problem/62572501>
Attachments
Patch (7.18 KB, patch)
2020-05-09 17:42 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.71 KB, patch)
2020-05-09 18:51 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.71 KB, patch)
2020-05-09 19:20 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2020-05-09 17:42:47 PDT
Created attachment 398949 [details] Patch
Tim Horton
Comment 2 2020-05-09 18:46:47 PDT
Comment on attachment 398949 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398949&action=review > Source/WebCore/rendering/RenderThemeMac.mm:869 > - if (style.appearance() == TextFieldPart || style.appearance() == TextAreaPart || style.appearance() == ListboxPart) > + if (style.appearance() == TextFieldPart || style.appearance() == TextAreaPart || style.appearance() == SearchFieldPart || style.appearance() == ListboxPart) At what point do we store appearance in a local to neaten this up?
Wenson Hsieh
Comment 3 2020-05-09 18:48:45 PDT
Comment on attachment 398949 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398949&action=review Thanks for the review! >> Source/WebCore/rendering/RenderThemeMac.mm:869 >> + if (style.appearance() == TextFieldPart || style.appearance() == TextAreaPart || style.appearance() == SearchFieldPart || style.appearance() == ListboxPart) > > At what point do we store appearance in a local to neaten this up? Fair point — I’ll go ahead and pull style.appearance() into a local variable while I’m here
Wenson Hsieh
Comment 4 2020-05-09 18:51:17 PDT Comment hidden (obsolete)
Wenson Hsieh
Comment 5 2020-05-09 19:20:36 PDT
Created attachment 398954 [details] Patch for landing
EWS
Comment 6 2020-05-09 20:05:44 PDT
Committed r261450: <https://trac.webkit.org/changeset/261450> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398954 [details].
Note You need to log in before you can comment on or make changes to this bug.