Bug 211644

Summary:

Remove empty directories from from svn.webkit.org repository

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

WebCore Misc.

Assignee:

David Kilzer (:ddkilzer) <ddkilzer>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, dino, ews-watchlist, graouts, graouts, jbedard, koivisto, kondapallykalyan, lmoura, pgriffis, pnormand, ryanhaddad, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=189081
https://bugs.webkit.org/show_bug.cgi?id=232773

Attachments:

Description	Flags
Patch v1	darin: review+

Description David Kilzer (:ddkilzer) 2020-05-08 14:37:02 PDT

Remove empty directories from from svn.webkit.org repository.

I updated my Subversion checkout of WebKit after about 18 months, and found sound empty directories:

I used this command to find and remove the empty directories:

$ for D in `find -d . -type d -and -not -name .svn | grep -v '/.svn'`; do if [ -z "`ls -A $D 2>&1`" ]; then echo ">>>> $D"; svn rm $D; fi; done 
[...]
$ svn stat .
D       LayoutTests/fast/events/touch/ios/iphone7
D       LayoutTests/fast/text-autosizing/ios/ipad
D       LayoutTests/fast/viewport/ios/ipad
D       LayoutTests/imported/mozilla/css-animations
D       LayoutTests/imported/mozilla/css-transitions
D       LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/AnimationEffectTiming
D       LayoutTests/legacy-animation-engine
D       LayoutTests/media/controls/ipad
D       LayoutTests/media/modern-media-controls/media-documents/ipad
D       LayoutTests/media/modern-media-controls/pip-support/ipad
D       LayoutTests/platform/gtk/legacy-animation-engine
D       LayoutTests/platform/ios/compositing/filters
D       LayoutTests/platform/ios/legacy-animation-engine
D       LayoutTests/platform/ios/media/modern-media-controls
D       LayoutTests/platform/ios-wk1/legacy-animation-engine
D       LayoutTests/platform/ios-wk2/legacy-animation-engine
D       LayoutTests/platform/iphone-7/tiled-drawing
D       LayoutTests/platform/mac/legacy-animation-engine
D       LayoutTests/platform/mac-wk1/compositing/plugins
D       LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/fetch/content-type
D       LayoutTests/platform/win/legacy-animation-engine
D       LayoutTests/platform/wincairo/legacy-animation-engine
D       LayoutTests/platform/wpe/legacy-animation-engine
D       LayoutTests/tiled-drawing/ios
D       Source/ThirdParty/ANGLE/include/vulkan
D       Source/ThirdParty/ANGLE/src/android_system_settings
D       Source/ThirdParty/ANGLE/third_party/glmark2
D       Source/ThirdParty/ANGLE/tools/flex-bison
D       Source/WebCore/Modules/webgpu/cocoa
D       Source/WebCore/page/scrolling/ios
D       Source/WebCore/platform/graphics/metal
D       Source/WebKit/UIProcess/API/win
D       Tools/BuildSlaveSupport/gtk
D       Tools/WebKitTestRunner/WebKitTestRunnerApp/en.lproj
D       Tools/flatpak/files
D       Tools/flatpak/patches

Any concerns about removing these directories?  (I will revert Tools/WebKitTestRunner/WebKitTestRunnerApp/en.lproj as In think that's used.)

Comment 1 David Kilzer (:ddkilzer) 2020-05-08 14:39:28 PDT

BTW, I can't post a patch (only a ChangeLog) because svn-create-patch doesn't currently support creating a patch that deletes directories, and git-svn basically ignores empty directories when checking out or updating a repository.

Comment 2 David Kilzer (:ddkilzer) 2020-05-08 17:10:46 PDT

Created attachment 398905 [details]
Patch v1

Comment 3 EWS Watchlist 2020-05-08 17:11:29 PDT

Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE

Comment 4 David Kilzer (:ddkilzer) 2020-05-08 18:23:26 PDT

Committed r261429: <https://trac.webkit.org/changeset/261429>

Comment 5 Radar WebKit Bug Importer 2020-05-08 18:24:16 PDT

<rdar://problem/63044462>

Comment 6 David Kilzer (:ddkilzer) 2020-05-19 12:18:49 PDT

Note to self or to future empty directory deleters:  The `find -d` switch does a depth-first search, which means the `find` command only needs to be run once instead of multiple times (see Bug 189081) to remove all the empty directories.