Bug 211643

Summary: Array.prototype.concat fast path checks should not be observable
Product: WebKit Reporter: Alexey Shvayka <ashvayka>
Component: JavaScriptCoreAssignee: Alexey Shvayka <ashvayka>
Status: RESOLVED FIXED    
Severity: Trivial CC: ews-watchlist, joepeck, keith_miller, mark.lam, msaboff, ross.kirsling, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=184267
Attachments:
Description Flags
Patch
none
Patch none

Alexey Shvayka
Reported 2020-05-08 14:32:06 PDT
Array.prototype.concat fast path checks should not be observable
Attachments
Patch (4.13 KB, patch)
2020-05-08 14:35 PDT, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
Patch (4.13 KB, patch)
2020-05-08 14:40 PDT, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Shvayka
Comment 1 2020-05-08 14:35:32 PDT
Created attachment 398889 [details] Patch
Alexey Shvayka
Comment 2 2020-05-08 14:40:56 PDT
Created attachment 398890 [details] Patch Tweak ChangeLog.
Ross Kirsling
Comment 3 2020-05-08 14:43:16 PDT
Comment on attachment 398890 [details] Patch Nice, glad to see that intrinsic is coming in handy. :)
Alexey Shvayka
Comment 4 2020-05-08 17:02:51 PDT
(In reply to Ross Kirsling from comment #3) > Comment on attachment 398890 [details] > Patch > > Nice, glad to see that intrinsic is coming in handy. :) Good job on implementing it and thanks for review! ARMv7 failure is unrelated: https://webkit.org/b/211313.
EWS
Comment 5 2020-05-08 18:43:47 PDT
Committed r261430: <https://trac.webkit.org/changeset/261430> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398890 [details].
Radar WebKit Bug Importer
Comment 6 2020-05-08 18:44:16 PDT
<rdar://problem/63044859>
Note You need to log in before you can comment on or make changes to this bug.