Bug 211634

Summary: [clang-tidy] Run modernize-use-using over WTF
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: Web Template FrameworkAssignee: Don Olmstead <don.olmstead>
Status: ASSIGNED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, darin, ews-watchlist
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP Patch none

Don Olmstead
Reported 2020-05-08 11:57:59 PDT
...
Attachments
WIP Patch (75.41 KB, patch)
2020-05-08 11:58 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2020-05-08 11:58:42 PDT
Created attachment 398878 [details] WIP Patch
Don Olmstead
Comment 2 2020-05-08 12:01:59 PDT
Current problematic constructs with the modernizer. Had some issues with these typedefs - typedef T* (PackedAlignedPtr::*UnspecifiedBoolType); + using UnspecifiedBoolType = T *(PackedAlignedPtr<T, >::*); It will totally destroy typedef enum code but we probably shouldn't be using those constructs anyways. typedef enum { LenientConversion, StrictConversion, StrictConversionReplacingUnpairedSurrogatesWithFFFD, } ConversionMode; Did have some issues with removing typedefs in Variant.h
Darin Adler
Comment 3 2020-05-08 13:40:13 PDT
Could do a quick pass first to remove all the "typedef enum" in the tree: Should be a mechanical process.
Note You need to log in before you can comment on or make changes to this bug.