Bug 211633

Summary: bmalloc should have per-cpu locking mechanism
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: bmallocAssignee: Yusuke Suzuki <ysuzuki>
Status: NEW    
Severity: Normal CC: annulen, ews-watchlist, ggaren, gyuyoung.kim, ryuan.choi, saam, sergio
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 211809    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Yusuke Suzuki
Reported 2020-05-08 11:06:15 PDT
We are taking a global lock easily. We should not. Talked with Phil, and current plan is introducing per-cpu locking mechanism. Each SmallPage have Mutex*, which could point to per-cpu lock or SmallPage's fine-grained lock. We switch them based on contention and keep deallocation fast without taking a global lock.
Attachments
Patch (39.35 KB, patch)
2020-05-18 19:08 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (39.49 KB, patch)
2020-05-18 19:35 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (58.34 KB, patch)
2020-05-19 00:25 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (49.68 KB, patch)
2020-05-20 16:10 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (62.31 KB, patch)
2020-05-20 17:36 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (83.47 KB, patch)
2020-05-20 18:15 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (83.82 KB, patch)
2020-05-20 18:26 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (83.46 KB, patch)
2020-05-26 12:00 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (92.37 KB, patch)
2020-06-02 06:57 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2020-05-08 12:00:36 PDT
This is awesome. I think this will help wasm compile times a lot
Yusuke Suzuki
Comment 2 2020-05-18 19:08:45 PDT
Created attachment 399696 [details] Patch WIP
Yusuke Suzuki
Comment 3 2020-05-18 19:35:34 PDT
Created attachment 399698 [details] Patch WIP
Yusuke Suzuki
Comment 4 2020-05-19 00:25:33 PDT
Created attachment 399717 [details] Patch WIP
Yusuke Suzuki
Comment 5 2020-05-20 16:10:59 PDT
Created attachment 399906 [details] Patch WIP
Yusuke Suzuki
Comment 6 2020-05-20 17:36:59 PDT
Created attachment 399919 [details] Patch WIP
Yusuke Suzuki
Comment 7 2020-05-20 18:15:12 PDT
Created attachment 399920 [details] Patch WIP
Yusuke Suzuki
Comment 8 2020-05-20 18:26:26 PDT
Created attachment 399921 [details] Patch WIP
Yusuke Suzuki
Comment 9 2020-05-26 12:00:04 PDT
Created attachment 400264 [details] Patch WIP
Yusuke Suzuki
Comment 10 2020-06-02 06:57:12 PDT
Created attachment 400814 [details] Patch WIP
Note You need to log in before you can comment on or make changes to this bug.