Summary: | Make WKWebViewConfiguration._alwaysRunsAtForegroundPriority an alias for _clientNavigationsRunAtForegroundPriority | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, darin, ggaren, thorton, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Chris Dumez
2020-05-08 10:27:36 PDT
Created attachment 398873 [details]
Patch
Comment on attachment 398873 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398873&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:94 > +@property (nonatomic, setter=_setAlwaysRunsAtForegroundPriority:) BOOL _alwaysRunsAtForegroundPriority WK_API_AVAILABLE(ios(9_0)); // This is now an alias for _clientNavigationsRunAtForegroundPriority. WK_API_DEPRECATED_WITH_REPLACEMENT (In reply to Alex Christensen from comment #2) > Comment on attachment 398873 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=398873&action=review > > > Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:94 > > +@property (nonatomic, setter=_setAlwaysRunsAtForegroundPriority:) BOOL _alwaysRunsAtForegroundPriority WK_API_AVAILABLE(ios(9_0)); // This is now an alias for _clientNavigationsRunAtForegroundPriority. > > WK_API_DEPRECATED_WITH_REPLACEMENT Isn't it going to cause build failures? (In reply to Chris Dumez from comment #3) > (In reply to Alex Christensen from comment #2) > > Comment on attachment 398873 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=398873&action=review > > > > > Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:94 > > > +@property (nonatomic, setter=_setAlwaysRunsAtForegroundPriority:) BOOL _alwaysRunsAtForegroundPriority WK_API_AVAILABLE(ios(9_0)); // This is now an alias for _clientNavigationsRunAtForegroundPriority. > > > > WK_API_DEPRECATED_WITH_REPLACEMENT > > Isn't it going to cause build failures? Not in places that matter (only at people's desks, which will then inspire them to fix things). Created attachment 398877 [details]
Patch
Comment on attachment 398877 [details] Patch Clearing flags on attachment: 398877 Committed r261407: <https://trac.webkit.org/changeset/261407> All reviewed patches have been landed. Closing bug. |