Make WKWebViewConfiguration._alwaysRunsAtForegroundPriority an alias for _clientNavigationsRunAtForegroundPriority

• Component: WebKit2
• Status: RESOLVED FIXED

[Chris Dumez]

Make WKWebViewConfiguration._alwaysRunsAtForegroundPriority an alias for _clientNavigationsRunAtForegroundPriority. _alwaysRunsAtForegroundPriority is a frequent source of process assertion leaks that get blamed on WebKit. Clients are using this in order to be able to do loads in background views so _clientNavigationsRunAtForegroundPriority should suffice and is not leak prone since the process assertion is released after the navigation has completed.

[Chris Dumez]

Created attachment 398873 [details]
Patch

[Alex Christensen]

Comment on attachment 398873 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398873&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:94
> +@property (nonatomic, setter=_setAlwaysRunsAtForegroundPriority:) BOOL _alwaysRunsAtForegroundPriority WK_API_AVAILABLE(ios(9_0)); // This is now an alias for _clientNavigationsRunAtForegroundPriority.

WK_API_DEPRECATED_WITH_REPLACEMENT

[Chris Dumez]

(In reply to Alex Christensen from comment #2)
> Comment on attachment 398873 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=398873&action=review
> 
> > Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:94
> > +@property (nonatomic, setter=_setAlwaysRunsAtForegroundPriority:) BOOL _alwaysRunsAtForegroundPriority WK_API_AVAILABLE(ios(9_0)); // This is now an alias for _clientNavigationsRunAtForegroundPriority.
> 
> WK_API_DEPRECATED_WITH_REPLACEMENT

Isn't it going to cause build failures?

[Tim Horton]

(In reply to Chris Dumez from comment #3)
> (In reply to Alex Christensen from comment #2)
> > Comment on attachment 398873 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=398873&action=review
> > 
> > > Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:94
> > > +@property (nonatomic, setter=_setAlwaysRunsAtForegroundPriority:) BOOL _alwaysRunsAtForegroundPriority WK_API_AVAILABLE(ios(9_0)); // This is now an alias for _clientNavigationsRunAtForegroundPriority.
> > 
> > WK_API_DEPRECATED_WITH_REPLACEMENT
> 
> Isn't it going to cause build failures?

Not in places that matter (only at people's desks, which will then inspire them to fix things).

[Chris Dumez]

Created attachment 398877 [details]
Patch

[Chris Dumez]

Comment on attachment 398877 [details]
Patch

Clearing flags on attachment: 398877

Committed r261407: <https://trac.webkit.org/changeset/261407>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/63033129>