Bug 211621 – [FlatPak SDK] Some packages in the SDK have missing debug symbols

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Carlos Alberto Lopez Perez]

On the backtrace from https://build.webkit.org/results/GTK%20Linux%2064-bit%20Debug%20(Tests)/r261362%20(6280)/compositing/video/video-border-radius-crash-log.txt there are missing symbols for some libraries of the SDK.

I observe that on:

/usr/lib/x86_64-linux-gnu/GL/lib/dri/swrast_dri.so
/usr/lib/x86_64-linux-gnu/ffmpeg/./libavcodec.so.58

[Philippe Normand]

Created attachment 398854 [details]
crash log

build bot links are not future-proof.

[Philippe Normand]

Created attachment 399121 [details]
Patch

[Philippe Normand]

(In reply to Carlos Alberto Lopez Perez from comment #0)
> On the backtrace from
> https://build.webkit.org/results/GTK%20Linux%2064-bit%20Debug%20(Tests)/
> r261362%20(6280)/compositing/video/video-border-radius-crash-log.txt there
> are missing symbols for some libraries of the SDK.
> 
> I observe that on:
> 
> /usr/lib/x86_64-linux-gnu/GL/lib/dri/swrast_dri.so

This should be better now with Sdk.Debug.

> /usr/lib/x86_64-linux-gnu/ffmpeg/./libavcodec.so.58

Unfortunately it seems the FDO ffmpeg flatpak extension is explicitly compiled without debug support.

[Carlos Alberto Lopez Perez]

(In reply to Philippe Normand from comment #3)
> (In reply to Carlos Alberto Lopez Perez from comment #0)
> > On the backtrace from
> > https://build.webkit.org/results/GTK%20Linux%2064-bit%20Debug%20(Tests)/
> > r261362%20(6280)/compositing/video/video-border-radius-crash-log.txt there
> > are missing symbols for some libraries of the SDK.
> > 
> > I observe that on:
> > 
> > /usr/lib/x86_64-linux-gnu/GL/lib/dri/swrast_dri.so
> 
> This should be better now with Sdk.Debug.
> 

I like the idea of installing Sdk.Debug also for release, but not sure how that will help with this specific bug, because the backtrace I posted above its already from the debug bot. And I understand Sdk.Debug was already installed there. However, the symbols for swrast_dri.so were missing.

[Philippe Normand]

webkit-flatpak --command=bash --debug
[📦🌐🐱 org.webkit.Webkit WebKit]$ file /usr/lib/x86_64-linux-gnu/GL/lib/dri/swrast_dri.so
/usr/lib/x86_64-linux-gnu/GL/lib/dri/swrast_dri.so: symbolic link to /usr/lib/x86_64-linux-gnu/GL/default/lib/dri/swrast_dri.so
[📦🌐🐱 org.webkit.Webkit WebKit]$ file /usr/lib/x86_64-linux-gnu/GL/default/lib/dri/swrast_dri.so
/usr/lib/x86_64-linux-gnu/GL/default/lib/dri/swrast_dri.so: symbolic link to libgallium_dri.so
[📦🌐🐱 org.webkit.Webkit WebKit]$ file /usr/lib/x86_64-linux-gnu/GL/default/lib/dri/libgallium_dri.so 
/usr/lib/x86_64-linux-gnu/GL/default/lib/dri/libgallium_dri.so: ELF 64-bit LSB shared object, x86-64, version 1 (GNU/Linux), dynamically linked, BuildID[sha1]=5ec01c8e318371839e3923926af535b2c6787298, stripped
[📦🌐🐱 org.webkit.Webkit WebKit]$

[Philippe Normand]

Perhaps we should build our own versions of the Mesa and ffmpeg extensions. Those shipped in Flathub are stripped and/or without debug support.

[Carlos Alberto Lopez Perez]

(In reply to Philippe Normand from comment #6)
> Perhaps we should build our own versions of the Mesa and ffmpeg extensions.
> Those shipped in Flathub are stripped and/or without debug support.

I see.

Maybe we can start by opening an issue on their bugtracker requesting to ship the debug symbols on the Debug flatpaks. ?


In any case I like the patch from this bug, I agree with the idea of installing also the flatpak debug layers also on release builds.

[Philippe Normand]

(In reply to Carlos Alberto Lopez Perez from comment #7)
> (In reply to Philippe Normand from comment #6)
> > Perhaps we should build our own versions of the Mesa and ffmpeg extensions.
> > Those shipped in Flathub are stripped and/or without debug support.
> 
> I see.
> 
> Maybe we can start by opening an issue on their bugtracker requesting to
> ship the debug symbols on the Debug flatpaks. ?
> 

Yes. I mentioned it on IRC and got no reply. Let's try a bugreport...

> 
> In any case I like the patch from this bug, I agree with the idea of
> installing also the flatpak debug layers also on release builds.

Thanks

[EWS]

Committed r261559: <https://trac.webkit.org/changeset/261559>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399121 [details].