Summary: | [macOS] Playhead in Touch Bar continues when loading stalls | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||||
Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | darin, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | Other | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Eric Carlson
2020-05-07 11:46:42 PDT
Created attachment 398771 [details]
Patch
Comment on attachment 398771 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398771&action=review > Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.mm:146 > + bool isPlaying = this->isPlaying() && !this->isStalled(); No need for the second "this->". The first one is needed because of a conflict with the name of the local variable we are setting. > Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.mm:436 > + return m_mediaElement ? m_mediaElement->readyState() <= HTMLMediaElement::HAVE_CURRENT_DATA : false; I like using && for expressions like this one. Comment on attachment 398771 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398771&action=review Thanks for the review! >> Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.mm:146 >> + bool isPlaying = this->isPlaying() && !this->isStalled(); > > No need for the second "this->". The first one is needed because of a conflict with the name of the local variable we are setting. Fixed. >> Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.mm:436 >> + return m_mediaElement ? m_mediaElement->readyState() <= HTMLMediaElement::HAVE_CURRENT_DATA : false; > > I like using && for expressions like this one. That is nicer, changed. Created attachment 398795 [details]
Patch for landing
Committed r261342: <https://trac.webkit.org/changeset/261342> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398795 [details]. |