Bug 211585 – [macOS] Playhead in Touch Bar continues when loading stalls

• Component: Media
• Status: RESOLVED FIXED

[Eric Carlson]

Playhead in Touch Bar should stop when loading stalls

[Eric Carlson]

<rdar://problem/33893306>

[Eric Carlson]

Created attachment 398771 [details]
Patch

[Darin Adler]

Comment on attachment 398771 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398771&action=review

> Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.mm:146
> +        bool isPlaying = this->isPlaying() && !this->isStalled();

No need for the second "this->". The first one is needed because of a conflict with the name of the local variable we are setting.

> Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.mm:436
> +    return m_mediaElement ? m_mediaElement->readyState() <= HTMLMediaElement::HAVE_CURRENT_DATA : false;

I like using && for expressions like this one.

[Eric Carlson]

Comment on attachment 398771 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398771&action=review

Thanks for the review!

>> Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.mm:146
>> +        bool isPlaying = this->isPlaying() && !this->isStalled();
> 
> No need for the second "this->". The first one is needed because of a conflict with the name of the local variable we are setting.

Fixed.

>> Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.mm:436
>> +    return m_mediaElement ? m_mediaElement->readyState() <= HTMLMediaElement::HAVE_CURRENT_DATA : false;
> 
> I like using && for expressions like this one.

That is nicer, changed.

[Eric Carlson]

Created attachment 398795 [details]
Patch for landing

[EWS]

Committed r261342: <https://trac.webkit.org/changeset/261342>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398795 [details].