Bug 211581

Summary: Delete code for old commit queue
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, ews-watchlist, glenn, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=211638
Bug Depends on:    
Bug Blocks: 213296    
Attachments:
Description Flags
Patch none

Aakash Jain
Reported 2020-05-07 10:18:20 PDT
old commit-queue was decommissioned few months back in favor of commit-queue on new ews (https://ews-build.webkit.org/#/builders/Commit-Queue). We should delete the code for old commit queue.
Attachments
Patch (66.48 KB, patch)
2020-05-07 10:21 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2020-05-07 10:21:22 PDT
Created attachment 398755 [details] Patch
Alexey Proskuryakov
Comment 2 2020-05-07 10:34:12 PDT
Comment on attachment 398755 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398755&action=review rs=me. Red is beautiful. > Tools/Scripts/webkitpy/tool/steps/validatechangelogs.py:40 > +# This is closely related to the ValidateReviewer step. Is ValidateReviewer still used?
Aakash Jain
Comment 3 2020-05-07 10:40:49 PDT
Comment on attachment 398755 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398755&action=review >> Tools/Scripts/webkitpy/tool/steps/validatechangelogs.py:40 >> +# This is closely related to the ValidateReviewer step. > > Is ValidateReviewer still used? Yes, ValidateChangeLogAndReviewer class in https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/ews-build/steps.py#L770 uses 'webkit-patch validate-changelog --check-oops --non-interactive'. ValidateChangelog uses ValidateReviewer when --non-interactive flag is passed.
Alexey Proskuryakov
Comment 4 2020-05-07 10:54:36 PDT
I wonder if anyone uses webkit-patch validate-changelog.
Aakash Jain
Comment 5 2020-05-07 11:10:47 PDT
(In reply to Alexey Proskuryakov from comment #4) > I wonder if anyone uses webkit-patch validate-changelog. new commit-queue uses it (in https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/ews-build/steps.py#L770) In new commit-queue, I simply used webkit-patch validate-changelog to perform changelog and reviewer validation. There is a large amount of logic which I did not want to re-implement/duplicate (so as to implement new commit-queue quickly). Especially logic to do fuzzy match for reviewer name/email/variation-of-name (e.g: matching 'Tim H' with 'Tim Horton').
EWS
Comment 6 2020-05-07 11:24:08 PDT
Committed r261319: <https://trac.webkit.org/changeset/261319> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398755 [details].
Radar WebKit Bug Importer
Comment 7 2020-05-07 11:25:15 PDT
<rdar://problem/62985206>
Note You need to log in before you can comment on or make changes to this bug.