Bug 211567

Summary: Make debug build run in accessibility isolated mode = 1.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: New BugsAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Andres Gonzalez
Reported 2020-05-07 07:00:58 PDT
Make debug build run in accessibility isolated mode = 1.
Attachments
Patch (8.41 KB, patch)
2020-05-07 07:14 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (10.41 KB, patch)
2020-05-07 09:13 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andres Gonzalez
Comment 1 2020-05-07 07:14:02 PDT
Created attachment 398735 [details] Patch
chris fleizach
Comment 2 2020-05-07 07:26:32 PDT
Comment on attachment 398735 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398735&action=review > Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:-481 > - if (!isMainThread()) { Can we leave this !iSMainThread but check which isolated tree mode we're in? and better yet add another assert? > Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:860 > + if (auto tree = this->tree()) same here > Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:290 > + ASSERT(m_changeLogLock.isLocked()); do we need to add the same thing for the focused node?
Andres Gonzalez
Comment 3 2020-05-07 09:13:56 PDT
Created attachment 398742 [details] Patch
EWS
Comment 4 2020-05-07 09:51:08 PDT
Committed r261300: <https://trac.webkit.org/changeset/261300> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398742 [details].
Radar WebKit Bug Importer
Comment 5 2020-05-07 09:52:14 PDT
<rdar://problem/62980582>
Note You need to log in before you can comment on or make changes to this bug.