Bug 211558

Summary:

Web Inspector: Sources: Breakpoints status not remembered/restored correctly

Product:

WebKit

Reporter:

Valentin Gjorgjioski <gjorgjioski>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Safari 13

Hardware:

All

OS:

All

Attachments:

Description	Flags
Video recording with bug description on STP 105	none
Patch	none

Valentin Gjorgjioski

Reported 2020-05-07 03:35:47 PDT

1. Open web inspector -> Sources. 2. Press Command+Y or Click the "Disable All Breakpoints" 3. Close the web inspector 4. Open the web inspector - Expecting All breakpoints to be disabled, but they are not. Related: https://stackoverflow.com/questions/61010199/breakpoints-in-safari-dev-tools-get-enabled-automatically/61654892#61654892 https://discussions.apple.com/thread/251235650?replyId=251235650021

Attachments
Video recording with bug description on STP 105 (9.11 MB, video/quicktime) 2020-05-07 12:55 PDT, Valentin Gjorgjioski	no flags	Details
Patch (1.80 KB, patch) 2020-05-07 13:31 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2020-05-07 09:38:50 PDT

I am unable to reproduce this in STP 105. Can you attach a video, or more detailed steps to reproduce?

Valentin Gjorgjioski

Comment 2 2020-05-07 12:55:59 PDT

Created attachment 398785 [details] Video recording with bug description on STP 105

Valentin Gjorgjioski

Comment 3 2020-05-07 13:12:33 PDT

Please see my last comment https://bugs.webkit.org/show_bug.cgi?id=211559#c10 on bug #211559.

Devin Rousso

Comment 4 2020-05-07 13:31:15 PDT

Created attachment 398790 [details] Patch

Joseph Pecoraro

Comment 5 2020-05-07 14:15:37 PDT

Comment on attachment 398790 [details] Patch Nice. r=me

EWS

Comment 6 2020-05-07 16:01:37 PDT

Committed r261340: <https://trac.webkit.org/changeset/261340> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398790 [details].

Radar WebKit Bug Importer

Comment 7 2020-05-07 16:02:22 PDT

<rdar://problem/62997044>

Note You need to log in before you can comment on or make changes to this bug.