Bug 211553

Summary: [GTK4] Stop using the GtkWidget.destroy vfunc
Product: WebKit Reporter: Adrian Perez <aperez>
Component: WebKitGTKAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, berto, bugs-noreply, cgarcia, ews-watchlist, gustavo
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 210100    
Attachments:
Description Flags
Patch none

Adrian Perez
Reported 2020-05-07 01:04:04 PDT
The GtkWidget.destroy vfunc is no more, and GObject.dispose should be used instead after the following merge request landed into GTK4: https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/1835 We only use .destroy in WebKitWebViewBase, and it looks like it should be possible to stop using .destroy for both GTK3 and GTK4 =)
Attachments
Patch (2.76 KB, patch)
2020-05-07 01:12 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2020-05-07 01:12:23 PDT
Created attachment 398711 [details] Patch
EWS Watchlist
Comment 2 2020-05-07 01:13:01 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
EWS
Comment 3 2020-05-07 02:05:40 PDT
Committed r261276: <https://trac.webkit.org/changeset/261276> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398711 [details].
Note You need to log in before you can comment on or make changes to this bug.