Bug 211516

Summary: [WebXR] Implement simulateUserActivation()
Product: WebKit Reporter: Sergio Villar Senin <svillar>
Component: New BugsAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, dino, svillar, webkit-bug-importer, youennf, zan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 211130    
Attachments:
Description Flags
Patch youennf: review+

Sergio Villar Senin
Reported 2020-05-06 08:46:50 PDT
[WebXR] Implement simulateUserActivation()
Attachments
Patch (5.06 KB, patch)
2020-05-06 08:55 PDT, Sergio Villar Senin 		youennf: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1 2020-05-06 08:55:17 PDT
Created attachment 398622 [details] Patch
youenn fablet
Comment 2 2020-05-06 09:15:43 PDT
Comment on attachment 398622 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398622&action=review > Source/WebCore/testing/WebXRTest.cpp:105 > + function.handleEvent(); it might be better to follow Internals::withUserGesture. Something like: UserGestureIndicator gestureIndicator(ProcessingUserGesture, document); function.handleEvent();
Sergio Villar Senin
Comment 3 2020-05-06 09:23:19 PDT
(In reply to youenn fablet from comment #2) > Comment on attachment 398622 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=398622&action=review > > > Source/WebCore/testing/WebXRTest.cpp:105 > > + function.handleEvent(); > > it might be better to follow Internals::withUserGesture. > Something like: > UserGestureIndicator gestureIndicator(ProcessingUserGesture, document); > function.handleEvent(); Much better indeed. I'll replace it before landing.
Sergio Villar Senin
Comment 4 2020-05-07 00:49:11 PDT
Committed r261273: <https://trac.webkit.org/changeset/261273>
Radar WebKit Bug Importer
Comment 5 2020-05-07 00:50:13 PDT
<rdar://problem/62965108>
Darin Adler
Comment 6 2020-05-07 12:20:52 PDT
Comment on attachment 398622 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398622&action=review > Source/WebCore/testing/XRSimulateUserActivationFunction.h:42 > + virtual CallbackResult<void> handleEvent(void) = 0; This (void) syntax is never needed in C++. It is sometimes needed in old C code. Just use "()".
Note You need to log in before you can comment on or make changes to this bug.