Bug 211393 – REGRESSION (r260228): Linker warning about limitsNavigationsToAppBoundDomains property overriding instance methods from class

• Component: WebKit2
• Status: RESOLVED FIXED

[David Kilzer (:ddkilzer)]

Linker warning about limitsNavigationsToAppBoundDomains/setLimitsNavigationsToAppBoundDomains: overriding instance method from class when building WebKit:

ld: warning: instance method 'setLimitsNavigationsToAppBoundDomains:' in category from WebKit.build/Debug/WebKit.build/Objects-normal/x86_64/UnifiedSource24-mm.o overrides method from class in WebKit.build/Debug/WebKit.build/Objects-normal/x86_64/UnifiedSource24-mm.o
ld: warning: instance method 'limitsNavigationsToAppBoundDomains' in category from WebKit.build/Debug/WebKit.build/Objects-normal/x86_64/UnifiedSource24-mm.o overrides method from class in WebKit.build/Debug/WebKit.build/Objects-normal/x86_64/UnifiedSource24-mm.o

I think this was introduced 2-3 weeks ago.  (Might be the cause of flaky behavior if the wrong method is being called.)

[David Kilzer (:ddkilzer)]

I first noticed this on Apr 17, 2020.

[David Kilzer (:ddkilzer)]

This warning means that the @property was added to the public header:

@property (nonatomic) BOOL limitsNavigationsToAppBoundDomains WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));

But the implementation was added to a category:

@implementation WKWebViewConfiguration (WKPrivate)
[...]
- (BOOL)limitsNavigationsToAppBoundDomains
{
    return _pageConfiguration->limitsNavigationsToAppBoundDomains();
}

- (void)setLimitsNavigationsToAppBoundDomains:(BOOL)limitsToAppBoundDomains
{
    _pageConfiguration->setLimitsNavigationsToAppBoundDomains(limitsToAppBoundDomains);
}
[...]
@end

[David Kilzer (:ddkilzer)]

Created attachment 398818 [details]
Patch v1

[David Kilzer (:ddkilzer)]

(In reply to David Kilzer (:ddkilzer) from comment #3)
> Created attachment 398818 [details]
> Patch v1

(I got tired of seeing the warning when building. :)

[Radar WebKit Bug Importer]

<rdar://problem/63004163>

[Brent Fulgham]

Comment on attachment 398818 [details]
Patch v1

r=me

[EWS]

Committed r261396: <https://trac.webkit.org/changeset/261396>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398818 [details].