Bug 21139

Summary: Profiler log message is wrong
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: Web Inspector (Deprecated)Assignee: Kevin McCullough <kmccullough>
Status: RESOLVED FIXED    
Severity: Normal CC: kmccullough
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch
oliver: review+
Proposed patch timothy: review+

Description Oliver Hunt 2008-09-26 05:12:23 PDT 
The message logged to the console when a profile has been completed uses the wrong number.

1. Open profile pane.
2. Start profiling
3. end profiling
4. look in the console

If you have just created profile 1, the console reports creating prfile 2
Comment 1 Kevin McCullough 2008-09-26 16:44:15 PDT 
It looks like the loop in linkifyStringAsFragment() happens twice and thus increments the profile count multiple times.
Comment 2 Kevin McCullough 2008-09-29 11:21:52 PDT 
The root cause is that the constructor for ConsoleMessage calls _format twice.  Once for this.message and once for this.formattedMessage.
Comment 3 Kevin McCullough 2008-09-29 11:59:24 PDT 
Created attachment 23912 [details]
Proposed patch
Comment 4 Kevin McCullough 2008-09-29 12:10:34 PDT 
Committed revision 37066.
Comment 5 Kevin McCullough 2008-09-30 13:01:21 PDT 
Reopening to fix correctly =(
Comment 6 Kevin McCullough 2008-09-30 13:02:14 PDT 
Created attachment 23950 [details]
Proposed patch
Comment 7 Timothy Hatcher 2008-09-30 13:17:48 PDT 
Comment on attachment 23950 [details]
Proposed patch

Don't land the change to Page.h.
Comment 8 Kevin McCullough 2008-09-30 13:27:18 PDT 
Committed revision 37106.