Bug 211383

Summary: [Cocoa] Remove a few unneeded __IPHONE_OS_VERSION_MIN_REQUIRED checks
Product: WebKit Reporter: Darin Adler <darin>
Component: New BugsAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ap: review+

Darin Adler
Reported 2020-05-04 09:03:51 PDT
[Cocoa] Remove a few unneeded __IPHONE_OS_VERSION_MIN_REQUIRED checks
Attachments
Patch (4.88 KB, patch)
2020-05-04 09:05 PDT, Darin Adler 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2020-05-04 09:05:45 PDT
Created attachment 398373 [details] Patch
Alexey Proskuryakov
Comment 2 2020-05-04 16:32:37 PDT
Comment on attachment 398373 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398373&action=review > Tools/TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:151 > +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400) || PLATFORM(IOS) || PLATFORM(WATCHOS) || PLATFORM(APPLETV) This check can be removed now, 10.14 is the oldest supported version for macOS. > Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:6534 > #if __IPHONE_OS_VERSION_MIN_REQUIRED > 130400 This can be removed too. We are 13.4+ now.
Darin Adler
Comment 3 2020-05-04 17:33:55 PDT
All right. I have some more patches coming up removing even more version checks.
Darin Adler
Comment 4 2020-05-04 18:01:32 PDT
Comment on attachment 398373 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398373&action=review >> Tools/TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:151 >> +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400) || PLATFORM(IOS) || PLATFORM(WATCHOS) || PLATFORM(APPLETV) > > This check can be removed now, 10.14 is the oldest supported version for macOS. OK, will do. >> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:6534 >> #if __IPHONE_OS_VERSION_MIN_REQUIRED > 130400 > > This can be removed too. We are 13.4+ now. Are you sure? This says > 130400, not >= 130400.
Darin Adler
Comment 5 2020-05-04 18:03:16 PDT
Committed r261134: <https://trac.webkit.org/changeset/261134>
Radar WebKit Bug Importer
Comment 6 2020-05-04 18:04:18 PDT
<rdar://problem/62870095>
Note You need to log in before you can comment on or make changes to this bug.