Bug 211303 – WebGPU: copyTextureToTexture() has an implementation bug (src copy view info is used also as dst)

• Component: WebGPU
• Status: RESOLVED FIXED

Summary:
WebGPU: copyTextureToTexture() has an implementation bug (src copy view info is used also as dst).

See:
GPUCommandBufferMetal.mm#214,217

[blitEncoder()
        copyFromTexture:src.texture->platformTexture()
        sourceSlice:src.arrayLayer
        sourceLevel:src.mipLevel
        sourceOrigin:MTLOriginMake(src.origin.x, src.origin.y, src.origin.z)
        sourceSize:MTLSizeMake(size.width, size.height, size.depth)
        toTexture:dst.texture->platformTexture()
        destinationSlice:src.arrayLayer
        destinationLevel:src.mipLevel
        destinationOrigin:MTLOriginMake(dst.origin.x, dst.origin.y, dst.origin.z)];

In particular:
        destinationSlice:src.arrayLayer
        destinationLevel:src.mipLevel

Should be:
        destinationSlice:dst.arrayLayer
        destinationLevel:dst.mipLevel

<rdar://problem/62266037>

Created attachment 398302 [details]
Patch

[Daniel Bates]

Comment on attachment 398302 [details]
Patch

Patch looks good.

Created attachment 398385 [details]
Patch for committing

[EWS]

[e-mail] does not have committer permissions according to https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

Rejecting attachment 398385 [details] from commit queue.

[EWS]

Committed r261089: <https://trac.webkit.org/changeset/261089>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398385 [details].