Bug 211242

Summary: REGRESSION (r247490): Leak of MiniBrowserNSTextFinder._hideInterfaceCallback
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 199815    
Bug Blocks:    
Attachments:
Description Flags
Patch v1
none
Patch v2 none

David Kilzer (:ddkilzer)
Reported 2020-04-30 11:23:53 PDT
Leak of MiniBrowserNSTextFinder._hideInterfaceCallback. Caused by: Bug 199815: NSTextFinder holes don't scroll with the page <https://bugs.webkit.org/show_bug.cgi?id=199815> <rdar://problem/52280514> <https://trac.webkit.org/r247490>
Attachments
Patch v1 (1.33 KB, patch)
2020-04-30 11:26 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
Patch v2 (1.33 KB, patch)
2020-04-30 11:28 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2020-04-30 11:26:10 PDT
Created attachment 398070 [details] Patch v1
David Kilzer (:ddkilzer)
Comment 2 2020-04-30 11:28:56 PDT
Created attachment 398071 [details] Patch v2
David Kilzer (:ddkilzer)
Comment 3 2020-04-30 11:29:47 PDT
(In reply to David Kilzer (:ddkilzer) from comment #1) > Created attachment 398070 [details] > Patch v1 Helps if you spell -release correctly.
Radar WebKit Bug Importer
Comment 4 2020-04-30 11:30:09 PDT
<rdar://problem/62662394>
Tim Horton
Comment 5 2020-04-30 11:30:57 PDT
Comment on attachment 398071 [details] Patch v2 We should totally ARC minibrowser
Radar WebKit Bug Importer
Comment 6 2020-04-30 11:30:58 PDT
<rdar://problem/62662314>
David Kilzer (:ddkilzer)
Comment 7 2020-04-30 11:39:30 PDT
<rdar://problem/62662394>
David Kilzer (:ddkilzer)
Comment 8 2020-04-30 11:58:51 PDT
Comment on attachment 398071 [details] Patch v2 MiniBrowser is not used in automated testing, so marking cq+ after all builds completed successfully.
EWS
Comment 9 2020-04-30 12:01:35 PDT
Committed r260958: <https://trac.webkit.org/changeset/260958> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398071 [details].
Note You need to log in before you can comment on or make changes to this bug.