Bug 211239

Summary: [GStreamer] Move video frame holder to its own file
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: PlatformAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, calvaris, cgarcia, eric.carlson, ews-watchlist, glenn, gustavo, gyuyoung.kim, jer.noble, menard, philipj, ryuan.choi, sergio, vjaquez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch achristensen: review+, calvaris: commit-queue-

Philippe Normand
Reported 2020-04-30 10:05:58 PDT
Refactoring.
Attachments
Patch (26.42 KB, patch)
2020-04-30 10:10 PDT, Philippe Normand 		achristensen: review+
calvaris: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2020-04-30 10:10:27 PDT
Created attachment 398060 [details] Patch
Xabier Rodríguez Calvar
Comment 2 2020-04-30 23:22:43 PDT
Comment on attachment 398060 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398060&action=review > Source/WebCore/platform/graphics/gstreamer/GStreamerVideoFrameHolder.cpp:8 > + * Copyright (C) 2007, 2009 Apple Inc. All rights reserved. > + * Copyright (C) 2007 Collabora Ltd. All rights reserved. > + * Copyright (C) 2007 Alp Toker <alp@atoker.com> > + * Copyright (C) 2009 Gustavo Noronha Silva <gns@gnome.org> > + * Copyright (C) 2014 Cable Television Laboratories, Inc. > + * Copyright (C) 2009, 2019, 2020 Igalia S.L > + * Copyright (C) 2015, 2019 Metrological Group B.V. This should be 2019 Igalia and Metro. The other holders don't belong here. > Source/WebCore/platform/graphics/gstreamer/GStreamerVideoFrameHolder.cpp:104 > + // Right now the TextureMapper only supports chromas with one plane .
Philippe Normand
Comment 3 2020-05-01 01:16:11 PDT
Committed r260987: <https://trac.webkit.org/changeset/260987>
Radar WebKit Bug Importer
Comment 4 2020-05-01 01:17:17 PDT
<rdar://problem/62711074>
Note You need to log in before you can comment on or make changes to this bug.