Bug 211204

Summary: build-jsc should quote the value of compile flags it forwards
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, fpizlo, ggaren, gskachkov, guijemont, keith_miller, mark.lam, msaboff, rmorisset, ross.kirsling, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Saam Barati
Reported 2020-04-29 13:56:09 PDT
For example, we do the wrong thing now with make when doing $ build-jsc --release ARCHS="x86_64 i386" We invoke make as $ make release ARCHS=x86_64 i386 instead of $ make release ARCHS="x86_64 i386"
Attachments
patch (1.92 KB, patch)
2020-04-29 14:16 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2020-04-29 14:16:45 PDT
Created attachment 397997 [details] patch
Mark Lam
Comment 2 2020-04-29 14:25:00 PDT
Comment on attachment 397997 [details] patch rs=me
EWS
Comment 3 2020-04-29 14:57:46 PDT
Committed r260917: <https://trac.webkit.org/changeset/260917> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397997 [details].
Radar WebKit Bug Importer
Comment 4 2020-04-29 14:58:14 PDT
<rdar://problem/62619195>
Note You need to log in before you can comment on or make changes to this bug.