Bug 211200 – Style is not applied when changed on the first line of a new mail message.

• Component: New Bugs
• Status: RESOLVED FIXED

[Megan Gardner]

Style is not applied when changed on the first line of a new mail message.

[Megan Gardner]

Created attachment 397990 [details]
Patch

[Megan Gardner]

Created attachment 398131 [details]
Patch

[Megan Gardner]

<rdar://problem/62087514>

[Megan Gardner]

Created attachment 398258 [details]
Patch

[Megan Gardner]

Created attachment 398259 [details]
Patch

[Megan Gardner]

Created attachment 398260 [details]
Patch

[Megan Gardner]

Created attachment 398413 [details]
Patch

[Megan Gardner]

Created attachment 398448 [details]
Patch

[Darin Adler]

Comment on attachment 398448 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398448&action=review

> LayoutTests/editing/execCommand/ios/first-line-text-attribute-change-presist-through-resigning-first-responder-expected.txt:3
> +U

This "U" line doesn’t seem to be present in the actual test output given what the EWS bot says.

[Darin Adler]

Comment on attachment 398448 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398448&action=review

r=me after you get the test to pass on EWS; right now it’s failing

> Tools/WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:71
> +#if PLATFORM(MAC)
> +    [[webView() window] makeFirstResponder:nil];
> +#else
>      [webView() resignFirstResponder];
> +#endif

I don’t think you should land this Mac-only change as part of this patch, since the test is an iOS-only test. I assume it’s not needed to make some other test pass on Mac?

I believe UIScriptControllerCocoa::becomeFirstResponder is also incorrect on Mac in the same sort of way. And should be fixed the same way, by calling [window makeFirstResponder:self]. Maybe not right now as part of this patch, though.

> LayoutTests/ChangeLog:10
> +        * editing/execCommand/ios/first-line-text-attribute-change-presist-through-resigning-first-responder.html: Added.

Why is this an iOS-only test? I couldn't find anything iOS-specific in it.

[Megan Gardner]

Comment on attachment 398448 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398448&action=review

>> LayoutTests/ChangeLog:10
>> +        * editing/execCommand/ios/first-line-text-attribute-change-presist-through-resigning-first-responder.html: Added.
> 
> Why is this an iOS-only test? I couldn't find anything iOS-specific in it.

It is the testing of resigningFirstResponder that is iOS specific. We do not resign at the same or similar times on Mac.

[Megan Gardner]

Created attachment 398511 [details]
Patch

[EWS]

Committed r261177: <https://trac.webkit.org/changeset/261177>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398511 [details].