Bug 211195

Summary: Add better handling of an uncleared bundle identifier in WebKitTestRunner
Product: WebKit Reporter: Kate Cheney <katherine_cheney>
Component: WebKit Misc.Assignee: Kate Cheney <katherine_cheney>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bfulgham, pvollan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Kate Cheney
Reported 2020-04-29 11:36:04 PDT
Calling exit(1) provides very little detail and makes debugging of this difficult.
Attachments
Patch (1.73 KB, patch)
2020-04-29 11:40 PDT, Kate Cheney 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.73 KB, patch)
2020-04-29 16:21 PDT, Kate Cheney 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kate Cheney
Comment 1 2020-04-29 11:36:32 PDT
<rdar://problem/62117145>
Kate Cheney
Comment 2 2020-04-29 11:40:08 PDT
Created attachment 397982 [details] Patch
Alexey Proskuryakov
Comment 3 2020-04-29 15:22:43 PDT
Comment on attachment 397982 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397982&action=review Thank you! > Tools/WebKitTestRunner/TestController.cpp:644 > + // ASSERT the bundle identifier has not already been set, since it can only be set once. I think that it would be better wording to not restate what the code does. So I'd say "The bundle identifier can only be set once." Maybe also add an explanation of how to resolve this, for the person hitting this. Something like this, if it's accurate: "WebContent process needs to be relaunched after every test that sets the bundle identifier."
Kate Cheney
Comment 4 2020-04-29 16:21:09 PDT
Created attachment 398007 [details] Patch for landing
Kate Cheney
Comment 5 2020-04-29 16:22:22 PDT
(In reply to Alexey Proskuryakov from comment #3) > Comment on attachment 397982 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=397982&action=review > > Thank you! > > > Tools/WebKitTestRunner/TestController.cpp:644 > > + // ASSERT the bundle identifier has not already been set, since it can only be set once. > > I think that it would be better wording to not restate what the code does. > So I'd say "The bundle identifier can only be set once." > > Maybe also add an explanation of how to resolve this, for the person hitting > this. Something like this, if it's accurate: "WebContent process needs to be > relaunched after every test that sets the bundle identifier." Thanks! I updated the comment. No resolution should be necessary from now on, because the bundleID will get cleared between all tests. I wrote that in the comment.
EWS
Comment 6 2020-04-29 16:42:10 PDT
Committed r260926: <https://trac.webkit.org/changeset/260926> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398007 [details].
Note You need to log in before you can comment on or make changes to this bug.