Bug 211183

Summary: [GTK][WPE] Create common glib expectation file
Product: WebKit Reporter: Lauro Moura <lmoura>
Component: Tools / TestsAssignee: Lauro Moura <lmoura>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, ews-watchlist, glenn, jbedard, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch without jhbuild paragraph none

Lauro Moura
Reported 2020-04-29 07:43:20 PDT
GTK and WPE share a number of components, like GStreamer and Soup, leading to common expectations for both bots in a number of tests (For example, Charlie Turner found 661 EME tests with common expectations between both ports). Currently: GTK: platform/gtk -> platform/wk2 -> generic GTK-wayland: platform/gtk-wayland -> platform/gtk -> platform/wk2 -> generic WPE: platform/wpe -> platform/wk2 -> generic Goal: GTK: platform/gtk -> platform/glib -> platform/wk2 -> generic GTK-wayland: platform/gtk-wayland -> platform/gtk -> platform/glib -> platform/wk2 -> generic WPE: platform/wpe -> platform/glib -> platform/wk2 -> generic
Attachments
Patch (10.83 KB, patch)
2020-04-29 07:48 PDT, Lauro Moura
no flags
Patch (16.25 KB, patch)
2020-04-29 09:53 PDT, Lauro Moura
no flags
Patch without jhbuild paragraph (15.91 KB, patch)
2020-04-29 12:25 PDT, Lauro Moura
no flags
Lauro Moura
Comment 1 2020-04-29 07:48:27 PDT
Lauro Moura
Comment 2 2020-04-29 08:08:16 PDT
Comment on attachment 397961 [details] Patch Didn't run testwebkitpy before. Will update. Sorry.
Lauro Moura
Comment 3 2020-04-29 09:53:57 PDT
Michael Catanzaro
Comment 4 2020-04-29 11:00:05 PDT
Comment on attachment 397971 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397971&action=review Nice! In the future, gtk-wayland expectations should go away since Wayland is default for ages. We can add gtk-x11 that inherits from main gtk results, like gtk-wayland does now. > LayoutTests/platform/glib/TestExpectations:9 > +# If you get different test results than the bots for some tests > +# even when using flatpak, then you can re-try using a > +# chroot of the same distro and version the bots use (see below). > +# If doing that fixes the issue, it means we need to identify the library > +# that is causing the difference on the results, and add it to Flatpak. That was true in jhbuild, not for flatpak. flatpak doesn't expose host dependencies at all, so the only way the host system should affect the test results would be via the very few things that flatpak exposes from the host system, most notably fonts.
Lauro Moura
Comment 5 2020-04-29 12:23:02 PDT
(In reply to Michael Catanzaro from comment #4) > In the future, gtk-wayland expectations should go away since Wayland is > default for ages. We can add gtk-x11 that inherits from main gtk results, > like gtk-wayland does now. Yeah. This could be done once we swap the main bots to wayland too (GTK-Release/GTK-Debug). (In reply to Michael Catanzaro from comment #4) > Comment on attachment 397971 [details] > That was true in jhbuild, not for flatpak. flatpak doesn't expose host > dependencies at all, so the only way the host system should affect the test > results would be via the very few things that flatpak exposes from the host > system, most notably fonts. True. For layout tests, even fonts should not be an issue, as flatpak bundles webkitgtk-test-fonts directly inside /usr/share and the WTR InjectedBundle searches there first. I'll remove this paragraph altogether.
Lauro Moura
Comment 6 2020-04-29 12:25:33 PDT
Created attachment 397986 [details] Patch without jhbuild paragraph
Michael Catanzaro
Comment 7 2020-04-29 12:54:39 PDT
(In reply to Lauro Moura from comment #5) > True. For layout tests, even fonts should not be an issue, as flatpak > bundles webkitgtk-test-fonts directly inside /usr/share and the WTR > InjectedBundle searches there first. I'll remove this paragraph altogether. Yes. But keyword is "should." :) The host fonts are exposed, and in theory could cause layout test failures if the tests are not careful to use only fonts provided by webkitgtk-test-fonts.
Michael Catanzaro
Comment 8 2020-04-29 12:56:02 PDT
BTW this looks good to me. I'd give r+, except I think cgarcia will want to approve a change of this magnitude.
EWS
Comment 9 2020-05-08 08:22:01 PDT
Committed r261383: <https://trac.webkit.org/changeset/261383> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397986 [details].
Radar WebKit Bug Importer
Comment 10 2020-05-08 08:23:33 PDT
Note You need to log in before you can comment on or make changes to this bug.