Bug 211169

Summary: Update SWServer.cpp originURL after https://trac.webkit.org/changeset/260707
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, cdumez, cturner, darin, koivisto, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=210431
Attachments:
Description Flags
Patch none

youenn fablet
Reported 2020-04-29 00:40:32 PDT
Update SWServer.cpp originURL after https://trac.webkit.org/changeset/260707
Attachments
Patch (1.33 KB, patch)
2020-04-29 00:52 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-04-29 00:52:47 PDT
Created attachment 397938 [details] Patch
youenn fablet
Comment 2 2020-04-29 00:53:10 PDT
<<rdar://problem/62541423>>
youenn fablet
Comment 3 2020-04-29 01:01:28 PDT
We could write an API test, but we would need to run a server on port 80 or 443. Not sure whether that is fine.
EWS
Comment 4 2020-04-29 09:55:13 PDT
Committed r260902: <https://trac.webkit.org/changeset/260902> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397938 [details].
Darin Adler
Comment 5 2020-04-29 11:40:43 PDT
Comment on attachment 397938 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397938&action=review > Source/WebCore/workers/service/server/SWServer.cpp:430 > - url.setPort(*origin.port()); > + url.setPort(origin.port()); Thanks for fixing this for me. Sorry I got it wrong!
youenn fablet
Comment 6 2020-05-01 10:54:31 PDT
*** Bug 211233 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.