Summary: | Audio from <audio> or <video> element continues after tab is closed | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | beidson, hyatt, koivisto | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Eric Carlson
2008-09-25 12:15:47 PDT
Created attachment 23816 [details]
proposed patch
the basic concept seems ok to me. I'd like to get comments from Hyatt or Brady. CC'ing them. Another option is to add the notification to Frame::pageDestroyed-- if we didn't want to change the willSaveToCache/didRestoreFromCache concept. FWIW, Antti suggested this approach. CC'ing him as well. I noticed that there are still some references to page cache left in connection with these callbacks. I see these in the patch: Document::m_pageCacheCallbackElements HTMLInputElement ::needsCacheCallback() HTMLMediaElement::m_inPageCache For consistency it would be good to rename them as well and check that semantics still make sense (that is they really care about whether document is active or not rather than specifically about being in page cache or not). At least something like HTMLMediaElement::m_inActiveDocument makes total sense. Created attachment 23851 [details]
revised patch
Revised patch per Antti's comments.
Comment on attachment 23851 [details]
revised patch
This should still be renamed to match variable name for consistency:
bool inPageCache() const { return !m_inActiveDocument; }
It should return the value without negation and call sites and should be reversed instead. (or alternatively find a good variable name that is true when inactive, m_inInactiveDocument sounds bad).
This is minor, r=me with or without the change.
|