Summary: | [GTK] update-webkitgtk-libs: TypeError: cannot use a string pattern on a bytes-like object | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> | ||||
Component: | WebKitGTK | Assignee: | Lauro Moura <lmoura> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bugs-noreply, lmoura, mcatanzaro, pnormand | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Michael Catanzaro
2020-04-28 13:42:02 PDT
Created attachment 397893 [details]
Patch
Comment on attachment 397893 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397893&action=review LGTM, thanks. > Tools/ChangeLog:12 > + Also check if the doc directory exists before passing it to bwrap. > + Should avoid errors like these: > + > + bwrap: Can't find source path /run/user/1000/doc: No such file or directory Hm, well I actually do have /run/user/1000/doc. That error must have been caused because the script was not mounting /run/user/1000/doc, it was mounting /run/user/b'1000'/doc. Oops. :) I'll let you decide whether it's still worth checking if that exists. (In reply to Michael Catanzaro from comment #2) > Comment on attachment 397893 [details] > Hm, well I actually do have /run/user/1000/doc. That error must have been > caused because the script was not mounting /run/user/1000/doc, it was > mounting /run/user/b'1000'/doc. Oops. :) I'll let you decide whether it's > still worth checking if that exists. Yeah, this is an issue that is happening in the WPE Debug test bot (and can happen if the dir does not exist). /Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Committed r260859: <https://trac.webkit.org/changeset/260859> |