Bug 211128

Summary: [GTK4] Add support for key events
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, berto, bugs-noreply, ews-watchlist, gustavo
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=211465
Bug Depends on:    
Bug Blocks: 210100    
Attachments:
Description Flags
Patch aperez: review+

Carlos Garcia Campos
Reported 2020-04-28 08:27:34 PDT
.
Attachments
Patch (18.38 KB, patch)
2020-04-28 08:33 PDT, Carlos Garcia Campos 		aperez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2020-04-28 08:33:22 PDT
Created attachment 397840 [details] Patch
EWS Watchlist
Comment 2 2020-04-28 08:34:27 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Adrian Perez
Comment 3 2020-04-28 12:38:28 PDT
Comment on attachment 397840 [details] Patch Is it me, or using event controllers is actually quite neat? :-)
Carlos Garcia Campos
Comment 4 2020-04-28 22:29:35 PDT
Committed r260869: <https://trac.webkit.org/changeset/260869>
Note You need to log in before you can comment on or make changes to this bug.