Bug 211090

Summary: Make HistoryController an inner class of FrameLoader
Product: WebKit Reporter: Rob Buis <rbuis>
Component: New BugsAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, ews-watchlist, japhet, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Rob Buis
Reported 2020-04-27 13:11:19 PDT
Make HistoryController an inner class of FrameLoader, this allows us to move some methods only used by HistoryController out of the FrameLoader public API.
Attachments
Patch (20.41 KB, patch)
2020-04-27 13:15 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (20.87 KB, patch)
2020-04-28 01:19 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2020-04-27 13:15:26 PDT
Created attachment 397725 [details] Patch
Rob Buis
Comment 2 2020-04-27 14:24:31 PDT
Comment on attachment 397725 [details] Patch PTAL. If this kind of design is acceptable I'd like to do the same for PolicyChecker and DocumentLoader, as especially the latter adds a lot of public API to FrameLoader that is only used by DocumentLoader, which could be made private. These classes all look tightly coupled to me BTW.
Darin Adler
Comment 3 2020-04-27 14:30:38 PDT
Comment on attachment 397725 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397725&action=review > Source/WebCore/loader/HistoryController.h:32 > -#include "FrameLoaderTypes.h" > +#include "FrameLoader.h" I’d think you could remove many of the includes below after making this change.
Rob Buis
Comment 4 2020-04-28 01:19:12 PDT
Created attachment 397819 [details] Patch
EWS
Comment 5 2020-04-28 02:11:50 PDT
Committed r260812: <https://trac.webkit.org/changeset/260812> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397819 [details].
Radar WebKit Bug Importer
Comment 6 2020-04-28 02:12:18 PDT
<rdar://problem/62499688>
Note You need to log in before you can comment on or make changes to this bug.