Bug 21106

Summary:

.in format discussed changes

Product:

WebKit

Reporter:

Julien Chaffraix <jchaffraix>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
First part: remove cppNamespace option, move the factory* options to the command line	none
Second part: change upperCaseName to interfaceName + some cleanup	none
Third part: include namespace into the interfaceName	mjs: review+
Final part: rename isAudioHack and clean up	darin: review+

Julien Chaffraix

Reported 2008-09-25 09:38:52 PDT

This is a follow up bug of my changes to the .in format. It is related to the discussion on webkit-dev on the enhancement that should be added (see https://lists.webkit.org/pipermail/webkit-dev/2008-June/004189.html for more info).

Attachments
*First part: remove cppNamespace option, move the factory options to the command line** (15.08 KB, patch) 2008-09-25 09:46 PDT, Julien Chaffraix	no flags	Details Formatted Diff Diff
Second part: change upperCaseName to interfaceName + some cleanup (7.93 KB, patch) 2008-09-30 11:06 PDT, Julien Chaffraix	no flags	Details Formatted Diff Diff
Third part: include namespace into the interfaceName (7.05 KB, patch) 2008-10-15 09:43 PDT, Julien Chaffraix	mjs: review+	Details Formatted Diff Diff
Final part: rename isAudioHack and clean up (5.02 KB, patch) 2008-11-19 17:36 PST, Julien Chaffraix	darin: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Julien Chaffraix

Comment 1 2008-09-25 09:46:05 PDT

Created attachment 23799 [details] First part: remove cppNamespace option, move the factory* options to the command line

Maciej Stachowiak

Comment 2 2008-09-26 00:58:25 PDT

Comment on attachment 23799 [details] First part: remove cppNamespace option, move the factory* options to the command line r=me

Julien Chaffraix

Comment 3 2008-09-30 10:05:58 PDT

Comment on attachment 23799 [details] First part: remove cppNamespace option, move the factory* options to the command line Committed in r37096.

Julien Chaffraix

Comment 4 2008-09-30 11:06:16 PDT

Created attachment 23944 [details] Second part: change upperCaseName to interfaceName + some cleanup

Maciej Stachowiak

Comment 5 2008-10-02 11:11:07 PDT

Comment on attachment 23944 [details] Second part: change upperCaseName to interfaceName + some cleanup r=me

Julien Chaffraix

Comment 6 2008-10-03 01:16:21 PDT

Comment on attachment 23944 [details] Second part: change upperCaseName to interfaceName + some cleanup Committed in r37231.

Julien Chaffraix

Comment 7 2008-10-15 09:43:00 PDT

Created attachment 24363 [details] Third part: include namespace into the interfaceName

Maciej Stachowiak

Comment 8 2008-11-06 16:08:55 PST

Comment on attachment 24363 [details] Third part: include namespace into the interfaceName r=me

Julien Chaffraix

Comment 9 2008-11-06 16:49:29 PST

Comment on attachment 24363 [details] Third part: include namespace into the interfaceName Committed in r38206.

Julien Chaffraix

Comment 10 2008-11-19 17:36:50 PST

Created attachment 25293 [details] Final part: rename isAudioHack and clean up After this patch, all the changes discussed on the mailing list should be addressed.

Darin Adler

Comment 11 2008-11-20 09:53:18 PST

Comment on attachment 25293 [details] Final part: rename isAudioHack and clean up wrapperOnlyIfMediaIsAvailable seems a little wordy, but I don't have a better suggestion. r=me

Julien Chaffraix

Comment 12 2008-11-20 11:40:51 PST

Landed in r38625.

Note You need to log in before you can comment on or make changes to this bug.