Bug 21106

Summary: .in format discussed changes
Product: WebKit Reporter: Julien Chaffraix <jchaffraix>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
First part: remove cppNamespace option, move the factory* options to the command line
none
Second part: change upperCaseName to interfaceName + some cleanup
none
Third part: include namespace into the interfaceName
mjs: review+
Final part: rename isAudioHack and clean up darin: review+

Description Julien Chaffraix 2008-09-25 09:38:52 PDT 
This is a follow up bug of my changes to the .in format. It is related to the discussion on webkit-dev on the enhancement that should be added (see https://lists.webkit.org/pipermail/webkit-dev/2008-June/004189.html for more info).
Comment 1 Julien Chaffraix 2008-09-25 09:46:05 PDT 
Created attachment 23799 [details]
First part: remove cppNamespace option, move the factory* options to the command line
Comment 2 Maciej Stachowiak 2008-09-26 00:58:25 PDT 
Comment on attachment 23799 [details]
First part: remove cppNamespace option, move the factory* options to the command line

r=me
Comment 3 Julien Chaffraix 2008-09-30 10:05:58 PDT 
Comment on attachment 23799 [details]
First part: remove cppNamespace option, move the factory* options to the command line

Committed in r37096.
Comment 4 Julien Chaffraix 2008-09-30 11:06:16 PDT 
Created attachment 23944 [details]
Second part: change upperCaseName to interfaceName + some cleanup
Comment 5 Maciej Stachowiak 2008-10-02 11:11:07 PDT 
Comment on attachment 23944 [details]
Second part: change upperCaseName to interfaceName + some cleanup

r=me
Comment 6 Julien Chaffraix 2008-10-03 01:16:21 PDT 
Comment on attachment 23944 [details]
Second part: change upperCaseName to interfaceName + some cleanup

Committed in r37231.
Comment 7 Julien Chaffraix 2008-10-15 09:43:00 PDT 
Created attachment 24363 [details]
Third part: include namespace into the interfaceName
Comment 8 Maciej Stachowiak 2008-11-06 16:08:55 PST 
Comment on attachment 24363 [details]
Third part: include namespace into the interfaceName

r=me
Comment 9 Julien Chaffraix 2008-11-06 16:49:29 PST 
Comment on attachment 24363 [details]
Third part: include namespace into the interfaceName

Committed in r38206.
Comment 10 Julien Chaffraix 2008-11-19 17:36:50 PST 
Created attachment 25293 [details]
Final part: rename isAudioHack and clean up

After this patch, all the changes discussed on the mailing list should be addressed.
Comment 11 Darin Adler 2008-11-20 09:53:18 PST 
Comment on attachment 25293 [details]
Final part: rename isAudioHack and clean up

wrapperOnlyIfMediaIsAvailable seems a little wordy, but I don't have a better suggestion.

r=me
Comment 12 Julien Chaffraix 2008-11-20 11:40:51 PST 
Landed in r38625.