Bug 211054

Summary: Warn when NeverDestroyed<Lock> is used
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: Tools / TestsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ews-watchlist, glenn, jbedard, mark.lam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Yusuke Suzuki
Reported 2020-04-26 14:07:05 PDT
Lock is designed to be constant-initialized. Just use `static Lock`, instead of `static NeverDestroyed<Lock>`. `static Lock` is cleaner, efficient, and further it fixes the potential race issue which `NeverDestroyed<Lock>` has.
Attachments
Patch (6.67 KB, patch)
2020-04-26 14:54 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2020-04-26 14:54:26 PDT
Created attachment 397631 [details] Patch
Yusuke Suzuki
Comment 2 2020-04-26 15:46:40 PDT
Comment on attachment 397631 [details] Patch EWS webkitpy is green.
EWS
Comment 3 2020-04-26 16:04:25 PDT
Committed r260734: <https://trac.webkit.org/changeset/260734> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397631 [details].
Radar WebKit Bug Importer
Comment 4 2020-04-26 16:05:13 PDT
<rdar://problem/62412350>
Note You need to log in before you can comment on or make changes to this bug.