Bug 211032 – [Flatpak SDK] Misc flatpakutils.py fixes

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Patrick Griffis]

Just a few fixes for issues I've hit.

[Patrick Griffis]

Created attachment 397589 [details]
Patch

[Patrick Griffis]

Created attachment 397590 [details]
Patch

[Patrick Griffis]

Created attachment 397592 [details]
Patch

[Patrick Griffis]

Created attachment 397594 [details]
Patch

[Patrick Griffis]

Created attachment 397624 [details]
Patch

[Philippe Normand]

ERROR: Tools/flatpak/flatpakutils.py:131:  [flatpak_check_output] Module 'subprocess' has no 'run' member  [pylint/E1101] [5]

[Lauro Moura]

(In reply to Philippe Normand from comment #6)
> ERROR: Tools/flatpak/flatpakutils.py:131:  [flatpak_check_output] Module
> 'subprocess' has no 'run' member  [pylint/E1101] [5]

subprocess.run was added in Python 3.5, per https://docs.python.org/3/library/subprocess.html#subprocess.run

Use the old Popen instead?

[Adrian Perez]

(In reply to Lauro Moura from comment #7)
> (In reply to Philippe Normand from comment #6)
> > ERROR: Tools/flatpak/flatpakutils.py:131:  [flatpak_check_output] Module
> > 'subprocess' has no 'run' member  [pylint/E1101] [5]
> 
> subprocess.run was added in Python 3.5, per
> https://docs.python.org/3/library/subprocess.html#subprocess.run
> 
> Use the old Popen instead?

Do we want to support Python 3 versions older than 3.5? I say no because:

 - Even Debian's “oldstable” has 3.5
 - 3.5 is considered one of the first Python 3 versions which are
   actually really usable (all is rosy with 3.6 or newer).
 - Support for 3.5 will end on 2020-09-13

Instead, I would figure out the issue with Pylint and keep using
“subprocess.run()”.

[Lauro Moura]

(In reply to Adrian Perez from comment #8)
> (In reply to Lauro Moura from comment #7)
> > (In reply to Philippe Normand from comment #6)
> > > ERROR: Tools/flatpak/flatpakutils.py:131:  [flatpak_check_output] Module
> > > 'subprocess' has no 'run' member  [pylint/E1101] [5]
> > 
> > subprocess.run was added in Python 3.5, per
> > https://docs.python.org/3/library/subprocess.html#subprocess.run
> > 
> > Use the old Popen instead?
> 
> Do we want to support Python 3 versions older than 3.5? I say no because:
> 
>  - Even Debian's “oldstable” has 3.5
>  - 3.5 is considered one of the first Python 3 versions which are
>    actually really usable (all is rosy with 3.6 or newer).
>  - Support for 3.5 will end on 2020-09-13
> 
> Instead, I would figure out the issue with Pylint and keep using
> “subprocess.run()”.

The issue would not be with Python3 itself, but with Python2. Don't we still need to support both versions in webkitpy?

(subprocess.run is not available in python2: https://docs.python.org/2/library/subprocess.html )

[Philippe Normand]

Right, webkitpy is not yet fully ported to Python3.

[Patrick Griffis]

Created attachment 398300 [details]
Patch

[Philippe Normand]

Comment on attachment 398300 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398300&action=review

> Tools/flatpak/flatpakutils.py:845
> +            icc_version_filename, = re.findall(rb'.*creating (.*)', tmpfile.read())

Breaks EWS:

Traceback (most recent call last):
  File "Tools/Scripts/update-webkit-flatpak", line 25, in <module>
    from flatpakutils import WebkitFlatpak
  File "./Tools/flatpak/flatpakutils.py", line 851
    icc_version_filename, = re.findall(rb'.*creating (.*)', tmpfile.read())
                                                         ^
SyntaxError: invalid syntax

[Patrick Griffis]

Created attachment 398328 [details]
Patch

[EWS]

Committed r261072: <https://trac.webkit.org/changeset/261072>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398328 [details].