Bug 210996

Summary: Call addExtraFieldsToRequest with current load type
Product: WebKit Reporter: Rob Buis <rbuis>
Component: New BugsAssignee: Rob Buis <rbuis>
Status: RESOLVED INVALID    
Severity: Normal CC: cdumez, darin, ews-watchlist, japhet
Priority: P2    
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Rob Buis
Reported 2020-04-24 14:18:16 PDT
Call addExtraFieldsToRequest with current load type, not the previous load type.
Attachments
Patch (2.28 KB, patch)
2020-04-24 14:20 PDT, Rob Buis 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2020-04-24 14:20:18 PDT
Created attachment 397508 [details] Patch
Darin Adler
Comment 2 2020-04-24 16:32:03 PDT
Comment on attachment 397508 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397508&action=review > Source/WebCore/ChangeLog:8 > + Call addExtraFieldsToRequest with current load type, not the previous load type. Is there any observable progression from this? If so, can we make a test demonstrating it? > Source/WebCore/loader/FrameLoader.cpp:1520 > + ResourceRequest& request = newDocumentLoader.request(); I would have suggested auto& here.
Note You need to log in before you can comment on or make changes to this bug.