Summary: | ASSERTION FAILED: m_wrapper under HTMLMediaElement::setIsPlayingToWirelessTarget | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
Component: | Media | Assignee: | Chris Dumez <cdumez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | calvaris, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, philipj, sergio, webkit-bug-importer, youennf | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Chris Dumez
2020-04-24 12:10:26 PDT
Created attachment 397481 [details]
Patch
Comment on attachment 397481 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397481&action=review > Source/WebCore/ChangeLog:14 > + No new tests, already covered by: > + media/modern-media-controls/placard-support/placard-support-airplay-fullscreen.html Is there any observable behavior change here in addition to not running into the GC issue? (In reply to Alexey Proskuryakov from comment #3) > Comment on attachment 397481 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=397481&action=review > > > Source/WebCore/ChangeLog:14 > > + No new tests, already covered by: > > + media/modern-media-controls/placard-support/placard-support-airplay-fullscreen.html > > Is there any observable behavior change here in addition to not running > into the GC issue? No. In release, we would fail to fire the event in this case and return early. In debug we would hit the assertion. Now we don't even try to fire the event so that we no longer hit the assertion in this case. No behavior change since we don't fire the event either way. Committed r260669: <https://trac.webkit.org/changeset/260669> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397481 [details]. > No. In release, we would fail to fire the event in this case and return
> early. In debug we would hit the assertion. Now we don't even try to fire
> the event so that we no longer hit the assertion in this case. No behavior
> change since we don't fire the event either way.
We would hit the assertion (or return in release) in the case where the wrapper was already GC collected. What about the case where it was not?
|