Bug 210980

Summary: Fix WASM Error classes and re-sync wpt/wasm/jsapi from upstream
Product: WebKit Reporter: Alexey Shvayka <ashvayka>
Component: JavaScriptCoreAssignee: Alexey Shvayka <ashvayka>
Status: RESOLVED FIXED    
Severity: Minor CC: darin, ews-watchlist, keith_miller, mail, mark.lam, mmaxfield, msaboff, ross.kirsling, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Alexey Shvayka
Reported 2020-04-24 11:22:18 PDT
Fix WASM Error classes and re-sync wpt/wasm/jsapi from upstream
Attachments
Patch (284.12 KB, patch)
2020-04-24 12:00 PDT, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
Patch (286.81 KB, patch)
2020-04-24 14:30 PDT, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Shvayka
Comment 1 2020-04-24 12:00:59 PDT
Created attachment 397479 [details] Patch
Keith Miller
Comment 2 2020-04-24 12:08:32 PDT
Comment on attachment 397479 [details] Patch r=me.
Keith Miller
Comment 3 2020-04-24 12:10:27 PDT
Comment on attachment 397479 [details] Patch Err, let's wait for EWS to run first.
Alexey Shvayka
Comment 4 2020-04-24 12:17:00 PDT
(In reply to Keith Miller from comment #3) > Comment on attachment 397479 [details] > Patch > > Err, let's wait for EWS to run first. Absolutely: it is easy to miss a file from staging or update platform-related expectations. Thank you for review, Keith.
Alexey Shvayka
Comment 5 2020-04-24 14:30:02 PDT
Created attachment 397509 [details] Patch Set reviewer and adjust WASM tests.
EWS
Comment 6 2020-04-24 21:58:42 PDT
Committed r260690: <https://trac.webkit.org/changeset/260690> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397509 [details].
Radar WebKit Bug Importer
Comment 7 2020-04-24 21:59:14 PDT
<rdar://problem/62361454>
Myles C. Maxfield
Comment 8 2020-04-24 22:59:49 PDT
This patch broke Apple's internal builds.
Yusuke Suzuki
Comment 9 2020-04-24 23:14:59 PDT
(In reply to Myles C. Maxfield from comment #8) > This patch broke Apple's internal builds. https://bugs.webkit.org/show_bug.cgi?id=211011
Yusuke Suzuki
Comment 10 2023-03-07 16:52:56 PST
*** Bug 204054 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.