Bug 210979 – check-webkit-style should recognize *Internal.h and *Private.h as primary headers

• Component: Tools / Tests
• Status: RESOLVED FIXED

[David Kilzer (:ddkilzer)]

check-webkit-style should recognize *Internal.h and *Private.h as primary headers.

For example, see style bot results from Bug 210974, Attachment #397471 [details]:

ERROR: Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm:29:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit/UIProcess/API/Cocoa/_WKActivatedElementInfo.mm:29:  Alphabetical sorting problem.  [build/include_order] [4]

<https://ews-build.webkit.org/#/builders/6/builds/19650>

[David Kilzer (:ddkilzer)]

Created attachment 397472 [details]
Patch v1

[Darin Adler]

Comment on attachment 397472 [details]
Patch v1

When making changes like this I like the idea of running check-webkit-style across the whole source tree, but there are probably *so* many messages when doing that, it’s not a great thing.

[David Kilzer (:ddkilzer)]

(In reply to Darin Adler from comment #2)
> Comment on attachment 397472 [details]
> Patch v1
> 
> When making changes like this I like the idea of running check-webkit-style
> across the whole source tree, but there are probably *so* many messages when
> doing that, it’s not a great thing.

You can do that by only running the checker you care about like this:

$ ./Tools/Scripts/check-webkit-style --filter=-,+build/include_order Source Tools

But there still might be^H^H^Hare a lot of build/include_order warnings.  (Too many "WARNING: File exempt from style guide. Skipping: ..." warnings as well.) For example, just running on Source/WebKit:

$ ./Tools/Scripts/check-webkit-style --filter=-,+build/include_order Source/WebKit
[...]
Total errors found: 291 in 3961 files

We probably need to break out "build/include_order" warnings into subcategories like build/include_order/alphabetical_sorting and build/include_order/missing_config_h eventually.

[David Kilzer (:ddkilzer)]

Comment on attachment 397472 [details]
Patch v1

Adding cq+ early since webkitpy tests passed, and this is a change that only affects check-webkit-style.

[EWS]

Committed r260659: <https://trac.webkit.org/changeset/260659>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397472 [details].

[Radar WebKit Bug Importer]

<rdar://problem/62328013>