Bug 210970

Summary: [EME][CDMProxy] Default initialize m_numDecryptorsWaitingForKey member
Product: WebKit Reporter: Charlie Turner <cturner>
Component: WebKitGTKAssignee: Charlie Turner <cturner>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, calvaris, dpino, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=210390
Attachments:
Description Flags
Patch none

Description Charlie Turner 2020-04-24 07:27:06 PDT 
[EME][CDMProxy] Default initialize m_numDecryptorsWaitingForKey member
Comment 1 Charlie Turner 2020-04-24 07:30:04 PDT 
Created attachment 397457 [details]
Patch
Comment 2 Xabier Rodríguez Calvar 2020-04-24 07:53:40 PDT 
Comment on attachment 397457 [details]
Patch

I think we should use wtf/Atomic instead.
Comment 3 Charlie Turner 2020-04-27 06:10:58 PDT 
(In reply to Xabier Rodríguez Calvar from comment #2)
> Comment on attachment 397457 [details]
> Patch
> 
> I think we should use wtf/Atomic instead.

Why? That's only a wrapper around std::atomic providing conveniences for CAS that are not relevant to us.
Comment 4 EWS 2020-04-28 03:58:29 PDT 
Committed r260815: <https://trac.webkit.org/changeset/260815>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397457 [details].