Bug 210954

Summary: Use @isUndefinedOrNull instead of abstract equality with null
Product: WebKit Reporter: Alexey Shvayka <ashvayka>
Component: JavaScriptCoreAssignee: Alexey Shvayka <ashvayka>
Status: RESOLVED FIXED    
Severity: Minor CC: ews-watchlist, joepeck, keith_miller, mark.lam, msaboff, ross.kirsling, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=193127
Attachments:
Description Flags
Patch
none
Patch none

Alexey Shvayka
Reported 2020-04-23 23:32:40 PDT
Use @isUndefinedOrNull instead of abstract equality with null
Attachments
Patch (9.29 KB, patch)
2020-04-23 23:36 PDT, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
Patch (11.66 KB, patch)
2020-05-18 13:11 PDT, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Shvayka
Comment 1 2020-04-23 23:36:59 PDT
Created attachment 397430 [details] Patch
Yusuke Suzuki
Comment 2 2020-04-23 23:50:30 PDT
Comment on attachment 397430 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397430&action=review r=me with comment. > Source/JavaScriptCore/ChangeLog:14 > + b) Replaces 3 `!= @undefined` and 7 `!= null` comparisons with @isUndefinedOrNull() > + as only the latter is correct with [[IsHTMLDDA]] aka MasqueradesAsUndefined objects [2]. Can you add a test with IsHTMLDDA? jsc shell has IsHTMLDDA mechanism so we can write a test for MasqueradesAsUndefined with JSC shell.
Alexey Shvayka
Comment 3 2020-05-18 13:11:00 PDT
Created attachment 399669 [details] Patch Rebase JSTests/test262/expectations.yaml and set reviewer.
Alexey Shvayka
Comment 4 2020-05-18 13:11:43 PDT
(In reply to Yusuke Suzuki from comment #2) > Can you add a test with IsHTMLDDA? jsc shell has IsHTMLDDA mechanism so we > can write a test for MasqueradesAsUndefined with JSC shell. I've added test262 coverage for all the comparisons fixed by this patch (r259587 introduced proper $262.IsHTMLDDA). These tests will be also beneficial for non-mainstream engines like Hermes, which, judging by source code (https://github.com/facebook/hermes/blob/b6530ae7e25604839c33b60261fb2832f49ca464/lib/InternalBytecode/String.js#L673), may have the same bug.
Alexey Shvayka
Comment 5 2020-05-18 13:13:15 PDT
Comment on attachment 399669 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399669&action=review > JSTests/test262/expectations.yaml:11 > test/annexB/built-ins/String/prototype/replaceAll/custom-replacer-emulates-undefined.js: This test is wrong. Upstream fix: https://github.com/tc39/test262/pull/2626.
EWS
Comment 6 2020-05-21 11:37:54 PDT
Committed r262017: <https://trac.webkit.org/changeset/262017> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399669 [details].
Radar WebKit Bug Importer
Comment 7 2020-05-21 11:38:17 PDT
<rdar://problem/63502823>
Note You need to log in before you can comment on or make changes to this bug.