Bug 210898

Summary: [Flatpak SDK] Install dependencies step needs configuration as argument
Product: WebKit Reporter: Diego Pino <dpino>
Component: New BugsAssignee: Diego Pino <dpino>
Severity: Normal CC: aakash_jain, ews-watchlist, pnormand, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch none

Description Diego Pino 2020-04-22 22:10:49 PDT
[Flatpak SDK] Install dependencies step needs configuration as argument
Comment 1 Diego Pino 2020-04-22 22:11:57 PDT
Created attachment 397319 [details]
Comment 2 Diego Pino 2020-04-22 22:17:02 PDT
While trying to switch WPE Debug build bot to Flatpak, I got the following error in 'compile-webkit' step:

Building flatpak based environment
Setting repo webkit-sdk URL from http://software.igalia.com/webkit-sdk-repo/ to https://software.igalia.com/webkit-sdk-repo/
Flatpak package org.webkit.Sdk.Debug/x86_64/0.2 not installed. Please update your SDK: Tools/Scripts/update-webkit-flatpak

See: https://build.webkit.org/builders/WPE%20Linux%2064-bit%20Debug%20%28Build%29/builds/18324

I think the reason why "org.webkit.Sdk.Debug" could not be located was that in the previous step, jhbuild, the script 'Tools/Scripts/update-webkitwpe-libs' run without arguments, so "Release" was assumed.

If I pass "--debug" to Tools/Scripts/update-webkitwpe-libs, and the run build-webkit, compilation works.
Comment 3 EWS 2020-04-23 01:47:41 PDT
Committed r260560: <https://trac.webkit.org/changeset/260560>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397319 [details].
Comment 4 Radar WebKit Bug Importer 2020-04-23 01:48:16 PDT
Comment 5 Philippe Normand 2020-04-23 04:21:45 PDT
Follow-up for jhbuild landed in r260565.
Comment 6 Aakash Jain 2020-04-24 06:12:36 PDT
Restarted build.webkit.org to pick up this change.