Bug 210879

Summary: AX: Improve tracking of Element* pointers in AXObjectCache with WeakHashSet
Product: WebKit Reporter: chris fleizach <cfleizach>
Component: AccessibilityAssignee: chris fleizach <cfleizach>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
none
patch
none
patch none

chris fleizach
Reported 2020-04-22 14:58:30 PDT
Realized we could make use of WeakHashSet <rdar://problem/58383764>
Attachments
patch (4.55 KB, patch)
2020-04-22 14:59 PDT, chris fleizach 		no flags
DetailsFormatted DiffDiff
patch (3.81 KB, patch)
2020-04-25 00:13 PDT, chris fleizach 		no flags
DetailsFormatted DiffDiff
patch (4.03 KB, patch)
2020-04-25 00:14 PDT, chris fleizach 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
chris fleizach
Comment 1 2020-04-22 14:59:30 PDT
Created attachment 397268 [details] patch
chris fleizach
Comment 2 2020-04-25 00:13:32 PDT
Created attachment 397546 [details] patch
chris fleizach
Comment 3 2020-04-25 00:14:52 PDT
Created attachment 397547 [details] patch
Daniel Bates
Comment 4 2020-04-25 08:06:06 PDT
Comment on attachment 397547 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=397547&action=review Patch looks good. > Source/WebCore/accessibility/AXObjectCache.h:490 > + WeakHashSet<Element> m_deferredRecomputeIsIgnoredList; This is a behavior change: weak set is UNORDERED, but list set is ORDERED. Is this OK?
EWS
Comment 5 2020-04-25 10:03:36 PDT
Committed r260706: <https://trac.webkit.org/changeset/260706> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397547 [details].
Note You need to log in before you can comment on or make changes to this bug.