Bug 210879

Summary:

AX: Improve tracking of Element* pointers in AXObjectCache with WeakHashSet

Product:

WebKit

Reporter:

chris fleizach <cfleizach>

Component:

Accessibility

Assignee:

chris fleizach <cfleizach>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	none
patch	none
patch	none

Description chris fleizach 2020-04-22 14:58:30 PDT

Realized we could make use of WeakHashSet


<rdar://problem/58383764>

Comment 1 chris fleizach 2020-04-22 14:59:30 PDT

Created attachment 397268 [details]
patch

Comment 2 chris fleizach 2020-04-25 00:13:32 PDT

Created attachment 397546 [details]
patch

Comment 3 chris fleizach 2020-04-25 00:14:52 PDT

Created attachment 397547 [details]
patch

Comment 4 Daniel Bates 2020-04-25 08:06:06 PDT

Comment on attachment 397547 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397547&action=review

Patch looks good.

> Source/WebCore/accessibility/AXObjectCache.h:490
> +    WeakHashSet<Element> m_deferredRecomputeIsIgnoredList;

This is a behavior change: weak set is UNORDERED, but list set is ORDERED. Is this OK?

Comment 5 EWS 2020-04-25 10:03:36 PDT

Committed r260706: <https://trac.webkit.org/changeset/260706>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397547 [details].